Highlight (reverse) hyperlinks on mouse hover

pkg/gui/controllers/helpers/confirmation_helper.go

@@ -259,7 +259,7 @@ func underlineLinks(text string) string {
 		} else {
 			linkEnd += linkStart
 		}
-		underlinedLink := style.PrintSimpleHyperlink(remaining[linkStart:linkEnd])
+		underlinedLink := style.PrintSimpleHyperlink(remaining[linkStart:linkEnd], true)
 		result += remaining[:linkStart] + underlinedLink
 		remaining = remaining[linkEnd:]
 	}

pkg/gui/controllers/status_controller.go

@@ -210,12 +210,12 @@ func (self *StatusController) showDashboard() error {
 		[]string{
 			lazygitTitle(),
 			fmt.Sprintf("Copyright %d Jesse Duffield", time.Now().Year()),
-			fmt.Sprintf("Keybindings: %s", style.PrintSimpleHyperlink(fmt.Sprintf(constants.Links.Docs.Keybindings, versionStr))),
-			fmt.Sprintf("Config Options: %s", style.PrintSimpleHyperlink(fmt.Sprintf(constants.Links.Docs.Config, versionStr))),
-			fmt.Sprintf("Tutorial: %s", style.PrintSimpleHyperlink(constants.Links.Docs.Tutorial)),
-			fmt.Sprintf("Raise an Issue: %s", style.PrintSimpleHyperlink(constants.Links.Issues)),
-			fmt.Sprintf("Release Notes: %s", style.PrintSimpleHyperlink(constants.Links.Releases)),
-			style.FgMagenta.Sprintf("Become a sponsor: %s", style.PrintSimpleHyperlink(constants.Links.Donate)), // caffeine ain't free
+			fmt.Sprintf("Keybindings: %s", style.PrintSimpleHyperlink(fmt.Sprintf(constants.Links.Docs.Keybindings, versionStr), true)),
+			fmt.Sprintf("Config Options: %s", style.PrintSimpleHyperlink(fmt.Sprintf(constants.Links.Docs.Config, versionStr), true)),
+			fmt.Sprintf("Tutorial: %s", style.PrintSimpleHyperlink(constants.Links.Docs.Tutorial, true)),
+			fmt.Sprintf("Raise an Issue: %s", style.PrintSimpleHyperlink(constants.Links.Issues, true)),
+			fmt.Sprintf("Release Notes: %s", style.PrintSimpleHyperlink(constants.Links.Releases, true)),
+			style.FgMagenta.Sprintf("Become a sponsor: %s", style.PrintSimpleHyperlink(constants.Links.Donate, true)), // caffeine ain't free
 		}, "\n\n") + "\n"
 
 	return self.c.RenderToMainViews(types.RefreshMainOpts{

pkg/gui/information_panel.go

@@ -14,8 +14,8 @@ func (gui *Gui) informationStr() string {
 	}
 
 	if gui.g.Mouse {
-		donate := style.FgMagenta.Sprint(style.PrintHyperlink(gui.c.Tr.Donate, constants.Links.Donate))
-		askQuestion := style.FgYellow.Sprint(style.PrintHyperlink(gui.c.Tr.AskQuestion, constants.Links.Discussions))
+		donate := style.FgMagenta.Sprint(style.PrintHyperlink(gui.c.Tr.Donate, constants.Links.Donate, true))
+		askQuestion := style.FgYellow.Sprint(style.PrintHyperlink(gui.c.Tr.AskQuestion, constants.Links.Discussions, true))
 		return fmt.Sprintf("%s %s %s", donate, askQuestion, gui.Config.GetVersion())
 	} else {
 		return gui.Config.GetVersion()

pkg/gui/style/hyperlink.go

@@ -3,11 +3,19 @@ package style
 import "fmt"
 
 // Render the given text as an OSC 8 hyperlink
-func PrintHyperlink(text string, link string) string {
-	return fmt.Sprintf("\033]8;;%s\033\\%s\033]8;;\033\\", link, text)
+func PrintHyperlink(text string, link string, underline bool) string {
+	result := fmt.Sprintf("\033]8;;%s\033\\%s\033]8;;\033\\", link, text)
+	if underline {
+		return AttrUnderline.Sprint(result)
+	}
+	return result
 }
 
 // Render a link where the text is the same as a link
-func PrintSimpleHyperlink(link string) string {
-	return fmt.Sprintf("\033]8;;%s\033\\%s\033]8;;\033\\", link, link)
+func PrintSimpleHyperlink(link string, underline bool) string {
+	result := fmt.Sprintf("\033]8;;%s\033\\%s\033]8;;\033\\", link, link)
+	if underline {
+		return AttrUnderline.Sprint(result)
+	}
+	return result
 }

pkg/utils/color_test.go

@@ -192,7 +192,11 @@ func TestDecolorise(t *testing.T) {
 			output: "ta",
 		},
 		{
-			input:  "a_" + style.PrintSimpleHyperlink("xyz") + "_b",
+			input:  "a_" + style.PrintSimpleHyperlink("xyz", true) + "_b",
+			output: "a_xyz_b",
+		},
+		{
+			input:  "a_" + style.PrintSimpleHyperlink("xyz", false) + "_b",
 			output: "a_xyz_b",
 		},
 	}