-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Provide user config defaults for UI-changeable settings #4717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f3164af
Fix keybinding display for local branches sort order to indicate it's…
stefanhaller 8d7bfd1
Move IgnoreWhitespaceInDiffView to user config
stefanhaller f318e45
Move DiffContextSize and RenameSimilarityThreshold to user config
stefanhaller d792836
Add missing validation tests
stefanhaller 703256e
Move LocalBranchSortOrder and RemoteBranchSortOrder to user config
stefanhaller 562a2aa
Un-deprecate UserConfig.Git.Log.Order and ShowGraph
stefanhaller 3575bb9
Add enum validation for Git.Log.Order and Git.Log.ShowGraph
stefanhaller 0d4f0e8
Add breaking changes entry for the changed sort order for branches
stefanhaller 9650753
Add configuration hints to existing tooltips
stefanhaller 6bfcb3d
Add tooltips for commit log menu
stefanhaller df48667
Add a prompt for the sort order menus for branches
stefanhaller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -366,6 +366,15 @@ git: | |||||
| allBranchesLogCmds: | ||||||
| - git log --graph --all --color=always --abbrev-commit --decorate --date=relative --pretty=medium | ||||||
|
|
||||||
| # If true, git diffs are rendered with the `--ignore-all-space` flag, which ignores whitespace changes. Can be toggled from within Lazygit with `<c-w>`. | ||||||
| ignoreWhitespaceInDiffView: false | ||||||
|
|
||||||
| # The number of lines of context to show around each diff hunk. Can be changed from within Lazygit with the `{` and `}` keys. | ||||||
| diffContextSize: 3 | ||||||
|
|
||||||
| # The threshold for considering a file to be renamed, in percent. Can be changed from within Lazygit with the `(` and `)` keys. | ||||||
| renameSimilarityThreshold: 50 | ||||||
|
|
||||||
| # If true, do not spawn a separate process when using GPG | ||||||
| overrideGpg: false | ||||||
|
|
||||||
|
|
@@ -387,9 +396,32 @@ git: | |||||
|
|
||||||
| # Config for showing the log in the commits view | ||||||
| log: | ||||||
| # One of: 'date-order' | 'author-date-order' | 'topo-order' | 'default' | ||||||
| # 'topo-order' makes it easier to read the git log graph, but commits may not | ||||||
| # appear chronologically. See https://git-scm.com/docs/ | ||||||
| # | ||||||
| # Can be changed from within Lazygit with `Log menu -> Commit sort order` (`<c-l>` in the commits window by default). | ||||||
| order: topo-order | ||||||
|
|
||||||
| # This determines whether the git graph is rendered in the commits panel | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| # One of 'always' | 'never' | 'when-maximised' | ||||||
| # | ||||||
| # Can be toggled from within lazygit with `Log menu -> Show git graph` (`<c-l>` in the commits window by default). | ||||||
| showGraph: always | ||||||
|
|
||||||
| # displays the whole git graph by default in the commits view (equivalent to passing the `--all` argument to `git log`) | ||||||
| showWholeGraph: false | ||||||
|
|
||||||
| # How branches are sorted in the local branches view. | ||||||
| # One of: 'date' (default) | 'recency' | 'alphabetical' | ||||||
| # Can be changed from within Lazygit with the Sort Order menu (`s`) in the branches panel. | ||||||
| localBranchSortOrder: date | ||||||
|
|
||||||
| # How branches are sorted in the remote branches view. | ||||||
| # One of: 'date' (default) | 'alphabetical' | ||||||
| # Can be changed from within Lazygit with the Sort Order menu (`s`) in the remote branches panel. | ||||||
| remoteBranchSortOrder: date | ||||||
|
|
||||||
| # When copying commit hashes to the clipboard, truncate them to this | ||||||
| # length. Set to 40 to disable truncation. | ||||||
| truncateCopiedCommitHashesTo: 12 | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe end this sentence, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an existing comment that I don't have much of a reason to change here (see diff in user_config.go). Also, most of the comments in this file don't end with a full stop, it seems. To be very honest I don't care too much...