Skip to content

Conversation

@stefanhaller
Copy link
Collaborator

Now that we can use 'k' as a menu item binding (this was fixed in #5131), use it for the "keep" entry in the merge menu. I don't think this will be a problem for people's muscle memory, given that this menu is not encountered every day; and it's simply the better keybinding.

This reverts commit b32b552.

@stefanhaller stefanhaller added the enhancement New feature or request label Dec 22, 2025
@stefanhaller
Copy link
Collaborator Author

FYI @zingazzi

@codacy-production
Copy link

codacy-production bot commented Dec 22, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 70fe7bd1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (70fe7bd) Report Missing Report Missing Report Missing
Head commit (6043eb5) 59289 51592 87.02%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#5132) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

stefanhaller added a commit that referenced this pull request Dec 22, 2025
…nus (#5131)

Previously they would be shown as keybindings in the menu, but they
didn't work because their builtin functionality (select next/prev line,
scroll view left/right) would take precedence.

This will allow us to revert #4934; doing that in a separate PR, see
#5132.
Now that we can use 'k' as a menu item binding (this was fixed in #5131), use it
for the "keep" entry in the merge menu. I don't think this will be a problem for
people's muscle memory, given that this menu is not encountered every day; and
it's simply the better keybinding.

This reverts commit b32b552.
@stefanhaller stefanhaller force-pushed the use-k-keybinding-for-keep-in-resolve-conflict-menu branch from efe1e06 to 6043eb5 Compare December 22, 2025 08:49
@stefanhaller stefanhaller merged commit 262e7f4 into master Dec 22, 2025
13 checks passed
@stefanhaller stefanhaller deleted the use-k-keybinding-for-keep-in-resolve-conflict-menu branch December 22, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants