Allow removing lines from patch directly

[jesseduffield]

I always press 'd' in the patch building view, expecting that I can do exactly what I can do in the staging view, to find out I need to go space -> ctrl+p -> d and I think it's time to honour the muscle memory and support this convenience keybinding. I recall we may have had a debate about this in the past and if so I'm renewing my stance.

PR Description

Please check if the PR fulfills these requirements

• Cheatsheets are up-to-date (run go generate ./...)
• Code has been formatted (see here)
• Tests have been added/updated (see here for the integration test guide)
• Text is internationalised (see here)
• If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
• Docs have been updated if necessary
• You've read through your own file changes for silly mistakes etc

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 1d0db511	✅ 88.71%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (1d0db51)	Report Missing	Report Missing	Report Missing
Head commit (81c96ef)	59747	52074	87.16%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#5277)	124	110	88.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[Copilot]

Pull request overview

Adds support for using the universal remove keybinding (typically d) in the patch building view to remove selected lines directly from a commit (mirroring staging view muscle memory), backed by new i18n strings, docs updates, and an integration test.

Changes:

• Add d/Universal.Remove keybinding in patch building view to remove selected lines from the commit via interactive rebase.
• Introduce new i18n strings for the new action (labels, tooltips, prompts, disabled reasons).
• Add an integration test and update generated keybindings docs accordingly.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pkg/gui/controllers/patch_building_controller.go	Adds Universal.Remove binding, disabled-reason logic, confirmation flow, and rebase-backed removal implementation.
pkg/i18n/english.go	Adds translation keys/strings for the new remove-lines-from-commit action and related errors/tooltips.
pkg/integration/tests/patch_building/remove_lines_from_commit.go	New integration test covering d in patch building view to remove a selected line from a commit.
pkg/integration/tests/test_list.go	Registers the new integration test.
docs-master/keybindings/Keybindings_*.md	Updates generated keybindings docs to include the new d action in patch building view across languages.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[stefanhaller]

Great, you beat me to it. I have had this on my todo list for quite a while.

It might take me a while to review it, I'm busy right now with work and private stuff, but I'll get to it eventually (and the other two PRs). Looking forward to using it.