-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Max height for JSQMessagesComposerTextView #323
Comments
@mrojas - let's see if there are other requests for this feature. i'd be happy to accept a PR, too. a |
this is a very logical augmentation.. |
it should actually be a pretty simple addition. |
I'll make a PR then :) |
I would love to have this feature as well. @mrojas Is there an update on the PR? |
All -- I've added this to the 6.2.0 milestone |
That's great. Thanks. |
…ut engine fault on iOS 7.x fixed. The problem itself can be observed when the pull request jessesquires#726 is applyed on top of v7.0.1+.
…umInputToolbarHeight to toolbar class.
I tried everything but input text field height doesn't increase when a longer text is typed in. How can i solve this issue? I am on ios 9. |
Hi! I'm getting the same issue as @samyakjain, how can i increase the height of the input toolbar? thanks! Also on iOS 9 |
@thesleepycow I guess you forgot to call the method in baseview , call [super ...] |
@samyakjain sorry but i don't quite understand what you mean.. I'm trying in swift with this code
|
i have done it in objective-c , you might be overriding this function,
make sure you call |
oh! it's working now. Thank you very much! |
hello @samyakjain in which class and place i will call this method [super observeValueForKeyPath:keyPath ofObject:object change:change context:context]; |
It would be nice if JSQMessagesComposerTextView had a property "maxHeight" or "maxLines", which is used to determine how tall the input field can grow.
Currently there is not limit, so if you type a huge message the text view takes the entire screen.
JSQMessagesComposerTextView is already observing UITextView notifications, so it could be done like described here: http://corecocoa.wordpress.com/2013/11/09/auto-growing-uitextview-using-auto-layout/
If "maxLines" is prefered, we can use the UIFont method to determine the line height.
Do you think this would be useful for other users?
The text was updated successfully, but these errors were encountered: