UICollectionView canPerformAction / shouldShowMenuForItemAtIndexPath

[ghazel]

Similar to #393, I would like to add menu items to some cells and disable the menu for others. It seems like the UICollectionView has some great functions for this (collectionView:canPerformAction:forItemAtIndexPath:withSender: collectionView:shouldShowMenuForItemAtIndexPath: etc) but JSQMessagesViewController doesn't use them.

Does it make sense to modify JSQMessagesCollectionViewCell to delegate to the collection view's delegate for menu handling?

[jessesquires]

@ghazel - yes this would be preferable.

the reason it is the way it is now is because using these methods on JSQMessagesViewController displays the menu above the cell, which sometimes means above the timestamp label, so it looks kind of weird (since it isn't displayed about the message bubble).

awhile back i tried to implement the collectionView methods instead, and then adjust the frame of the menu, but had no luck.

[jessesquires]

Here's an attempt to move the UIMenuController handling from the collectionViewCell to the collectionView. You can see that it gets pretty ugly rather quickly, trying to find which cell was selected and then the correct frame for the bubble view.

8c9201e

[ghazel]

Wow, that does seem like more work than I expected.

Why not handle the menu in the cell, but dispatch actions and canPerform to the collection?

[jessesquires]

@ghazel - yeah it makes me 😢 - the real problem is that when the menuWillShow notification is called, [self.collectionView indexPathsForSelectedItems] is empty. Otherwise, we could grab the currently selected cell, and set the menu's targetRect to the cell's messageBubbleImageView.

Why not handle the menu in the cell, but dispatch actions and canPerform to the collection?

That's an interesting idea. How exactly do you think this should work? You want to submit a PR? 😄

[ghazel]

Here's what I was thinking: #463

[jessesquires]

so i just realized that the shouldShowMenuForItemAtIndexPath: and other delegate methods for the menu controller pass the indexPath.

so we can just save that indexPath and then this is super trivial. getting a fix together now.

i have no idea what i was thinking yesterday.