Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to modern JS + ESM, tests rewritten on tap-esm, removed deps #91

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Refactoring to modern JS + ESM, tests rewritten on tap-esm, removed deps #91

merged 1 commit into from
Feb 10, 2023

Conversation

MaksimLavrenyuk
Copy link
Collaborator

No description provided.

@jessetane jessetane merged commit 15d0bd3 into jessetane:master Feb 10, 2023
@jessetane
Copy link
Owner

Alright, nice work! Next PR maybe can focus on switching events dep to EventTarget?

@jessetane
Copy link
Owner

Also for future PRs can you work on feature branches rather than master? The history will make more sense, you can work on more than one thing at a time, rebase if master moves out from under you, etc. e.g. https://docs.github.com/en/get-started/quickstart/github-flow

@MaksimLavrenyuk
Copy link
Collaborator Author

@jessetane

Yes, the next PR focus is on EventTarget.

I apologize for the branch/commit confusion in the previous PR. This is my first PR on github. I don't want to make excuses, but it was a surprise to me that on github you can't change a branch after creating a PR (I mostly use gitlab, it has such functionality). Since I originally linked to master and there were references to it in the issue with discussion, I was afraid to create a new PR. Which, in the end, I still had to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants