feat: add valid-title to recommended ruleset

BREAKING CHANGE: recommend `valid-title` rule
jest-community · Sep 4, 2020 · 41f7873 · 41f7873
1 parent 7080952
commit 41f7873
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -169,7 +169,7 @@ installations requiring long-term consistency.
 | [valid-describe](docs/rules/valid-describe.md)                               | Enforce valid `describe()` callback                             | ![recommended][] |              |
 | [valid-expect](docs/rules/valid-expect.md)                                   | Enforce valid `expect()` usage                                  | ![recommended][] |              |
 | [valid-expect-in-promise](docs/rules/valid-expect-in-promise.md)             | Enforce having return statement when testing with promises      | ![recommended][] |              |
-| [valid-title](docs/rules/valid-title.md)                                     | Enforce valid titles                                            |                  | ![fixable][] |
+| [valid-title](docs/rules/valid-title.md)                                     | Enforce valid titles                                            | ![recommended][] | ![fixable][] |
 
 <!-- end rules list -->
 

diff --git a/src/__tests__/__snapshots__/rules.test.ts.snap b/src/__tests__/__snapshots__/rules.test.ts.snap
@@ -80,6 +80,7 @@ Object {
       "jest/valid-describe": "error",
       "jest/valid-expect": "error",
       "jest/valid-expect-in-promise": "error",
+      "jest/valid-title": "error",
     },
   },
   "style": Object {

diff --git a/src/rules/valid-title.ts b/src/rules/valid-title.ts
@@ -81,7 +81,7 @@ export default createRule<[Options], MessageIds>({
     docs: {
       category: 'Best Practices',
       description: 'Enforce valid titles',
-      recommended: false,
+      recommended: 'error',
     },
     messages: {
       titleMustBeString: 'Title must be a string',