Skip to content

Commit

Permalink
feat: drop support for node 8 (#570)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Node 10+ required
  • Loading branch information
G-Rath authored and SimenB committed Sep 4, 2020
1 parent ede9152 commit 6788e72
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [8.x, 10.x, 12.x, 13.x, 14.x]
node-version: [10.x, 12.x, 14.x]
eslint-version: [5, 6, 7]
exclude:
# eslint@7 doesn't support node@8
- node-version: 8.x
eslint-version: 7
runs-on: ubuntu-latest

steps:
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ module.exports = {
plugins: ['replace-ts-export-assignment'],
presets: [
'@babel/preset-typescript',
['@babel/preset-env', { targets: { node: 8 } }],
['@babel/preset-env', { targets: { node: 10 } }],
],
};
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
"eslint": ">=5"
},
"engines": {
"node": ">=8"
"node": ">=10"
},
"release": {
"plugins": [
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"target": "es2015",
"module": "commonjs",
"moduleResolution": "node",
"lib": ["es2018"],
"noEmit": true,
"noImplicitReturns": true,
"strict": true,
Expand Down

0 comments on commit 6788e72

Please sign in to comment.