refactor: require rule file in tests (#85)

jest-community · Feb 17, 2018 · 6f2256b · 6f2256b
1 parent 092514b
commit 6f2256b
Show file tree

Hide file tree

Showing 14 changed files with 248 additions and 270 deletions.
diff --git a/rules/__tests__/consistent-test-it.test.js b/rules/__tests__/consistent-test-it.test.js
diff --git a/rules/__tests__/lowercase-name.test.js b/rules/__tests__/lowercase-name.test.js
@@ -1,15 +1,15 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../lowercase-name');
 
 const ruleTester = new RuleTester({
  parserOptions: {
  ecmaVersion: 6,
  },
 });
 
-ruleTester.run('lowercase-name', rules['lowercase-name'], {
+ruleTester.run('lowercase-name', rule, {
  valid: [
  "it(' ', function () {})",
  'it(" ", function () {})',

diff --git a/rules/__tests__/no-disabled-tests.test.js b/rules/__tests__/no-disabled-tests.test.js
@@ -1,11 +1,11 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../no-disabled-tests');
 
 const ruleTester = new RuleTester();
 
-ruleTester.run('no-disabled-tests', rules['no-disabled-tests'], {
+ruleTester.run('no-disabled-tests', rule, {
  valid: [
  'describe("foo", function () {})',
  'it("foo", function () {})',

diff --git a/rules/__tests__/no-focused-tests.test.js b/rules/__tests__/no-focused-tests.test.js
@@ -1,12 +1,12 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../no-focused-tests');
 
 const ruleTester = new RuleTester();
 const expectedErrorMessage = 'Unexpected focused test.';
 
-ruleTester.run('no-focused-tests', rules['no-focused-tests'], {
+ruleTester.run('no-focused-tests', rule, {
  valid: [
  'describe()',
  'it()',

diff --git a/rules/__tests__/no-hooks.test.js b/rules/__tests__/no-hooks.test.js
@@ -1,14 +1,15 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../no-hooks');
+
 const ruleTester = new RuleTester({
  parserOptions: {
  ecmaVersion: 6,
  },
 });
 
-ruleTester.run('no-hooks', rules['no-hooks'], {
+ruleTester.run('no-hooks', rule, {
  valid: [
  'test("foo")',
  'describe("foo", () => { it("bar") })',

diff --git a/rules/__tests__/no-identical-title.test.js b/rules/__tests__/no-identical-title.test.js
@@ -1,11 +1,11 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../no-identical-title');
 
 const ruleTester = new RuleTester();
 
-ruleTester.run('no-identical-title', rules['no-identical-title'], {
+ruleTester.run('no-identical-title', rule, {
  valid: [
  [
  'describe("describe", function() {',

diff --git a/rules/__tests__/no-test-prefixes.test.js b/rules/__tests__/no-test-prefixes.test.js
@@ -1,11 +1,11 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../no-test-prefixes');
 
 const ruleTester = new RuleTester();
 
-ruleTester.run('no-test-prefixes', rules['no-test-prefixes'], {
+ruleTester.run('no-test-prefixes', rule, {
  valid: [
  'describe("foo", function () {})',
  'it("foo", function () {})',

diff --git a/rules/__tests__/prefer-expect-assertions.test.js b/rules/__tests__/prefer-expect-assertions.test.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../prefer-expect-assertions');
 
 const ruleTester = new RuleTester({
  parserOptions: {
@@ -12,7 +12,7 @@ const ruleTester = new RuleTester({
 const expectedMsg =
  'Every test should have either `expect.assertions(<number of assertions>)` or `expect.hasAssertions()` as its first expression';
 
-ruleTester.run('prefer-expect-assertions', rules['prefer-expect-assertions'], {
+ruleTester.run('prefer-expect-assertions', rule, {
  invalid: [
  {
  code: 'it("it1", () => {})',

diff --git a/rules/__tests__/prefer-to-be-null.test.js b/rules/__tests__/prefer-to-be-null.test.js
@@ -1,11 +1,11 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../../').rules;
+const rule = require('../prefer-to-be-null');
 
 const ruleTester = new RuleTester();
 
-ruleTester.run('prefer_to_be_null', rules['prefer-to-be-null'], {
+ruleTester.run('prefer-to-be-null', rule, {
  valid: [
  'expect(null).toBeNull();',
  'expect(null).toEqual();',

diff --git a/rules/__tests__/prefer-to-be-undefined.test.js b/rules/__tests__/prefer-to-be-undefined.test.js
@@ -1,11 +1,11 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../../').rules;
+const rule = require('../prefer-to-be-undefined');
 
 const ruleTester = new RuleTester();
 
-ruleTester.run('prefer_to_be_undefined', rules['prefer-to-be-undefined'], {
+ruleTester.run('prefer-to-be-undefined', rule, {
  valid: [
  'expect(undefined).toBeUndefined();',
  'expect(true).not.toBeUndefined();',

diff --git a/rules/__tests__/prefer-to-have-length.test.js b/rules/__tests__/prefer-to-have-length.test.js
@@ -1,11 +1,11 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../prefer-to-have-length');
 
 const ruleTester = new RuleTester();
 
-ruleTester.run('prefer_to_have_length', rules['prefer-to-have-length'], {
+ruleTester.run('prefer-to-have-length', rule, {
  valid: [
  'expect(files).toHaveLength(1);',
  "expect(files.name).toBe('file');",

diff --git a/rules/__tests__/valid-describe.test.js b/rules/__tests__/valid-describe.test.js
@@ -1,15 +1,15 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../valid-describe');
 
 const ruleTester = new RuleTester({
  parserOptions: {
  ecmaVersion: 8,
  },
 });
 
-ruleTester.run('valid-describe', rules['valid-describe'], {
+ruleTester.run('valid-describe', rule, {
  valid: [
  'describe("foo", function() {})',
  'describe("foo", () => {})',

diff --git a/rules/__tests__/valid-expect-in-promise.test.js b/rules/__tests__/valid-expect-in-promise.test.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../valid-expect-in-promise');
 
 const ruleTester = new RuleTester({
  parserOptions: {
@@ -12,7 +12,7 @@ const ruleTester = new RuleTester({
 const expectedMsg =
  'Promise should be returned to test its fulfillment or rejection';
 
-ruleTester.run('valid-expect-in-promise', rules['valid-expect-in-promise'], {
+ruleTester.run('valid-expect-in-promise', rule, {
  invalid: [
  {
  code: `

diff --git a/rules/__tests__/valid-expect.test.js b/rules/__tests__/valid-expect.test.js
@@ -1,11 +1,11 @@
 'use strict';
 
 const RuleTester = require('eslint').RuleTester;
-const rules = require('../..').rules;
+const rule = require('../valid-expect');
 
 const ruleTester = new RuleTester();
 
-ruleTester.run('valid-expect', rules['valid-expect'], {
+ruleTester.run('valid-expect', rule, {
  valid: [
  'expect("something").toEqual("else");',
  'expect(true).toBeDefined();',