fix(no-large-snapshots): avoid instanceof RegExp check for ESLint v9 compatibility
#1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
# [28.0.0-next.6](v28.0.0-next.5...v28.0.0-next.6) (2024-03-29) ### Bug Fixes * **no-large-snapshots:** avoid `instanceof RegExp` check for ESLint v9 compatibility ([#1542](#1542)) ([af4a9c9](af4a9c9))
|
🎉 This PR is included in version 28.0.0-next.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 6, 2024
# [28.0.0](v27.9.0...v28.0.0) (2024-04-06) ### Bug Fixes * allow ESLint 9 as peer dependency ([#1547](#1547)) ([3c5e167](3c5e167)) * drop support for Node 19 ([#1548](#1548)) ([c87e388](c87e388)) * **no-large-snapshots:** avoid `instanceof RegExp` check for ESLint v9 compatibility ([#1542](#1542)) ([af4a9c9](af4a9c9)) ### Features * drop support for `@typescript-eslint/eslint-plugin` v5 ([#1530](#1530)) ([150e355](150e355)) * drop support for Node v14 ([#1527](#1527)) ([df5e580](df5e580)) * remove `no-if` rule ([#1528](#1528)) ([f976fc8](f976fc8)) * remove `snapshot` processor and `flat/snapshot` config ([#1532](#1532)) ([98087f9](98087f9)) * upgrade `@typescript-eslint/utils` to v6 ([#1508](#1508)) ([dc6e8cd](dc6e8cd)) ### BREAKING CHANGES * Node v19 is no longer supported * removed unneeded `snapshot` processor and `flat/snapshot` config * dropped support for `@typescript-eslint/eslint-plugin` v5 * dropped support for Node v14 * removed `no-if` in favor of `no-conditional-in-test`
|
🎉 This PR is included in version 28.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #1534 - it seems that globals are different in ESLint v9 resulting in the same issue with
instanceofthat Jest has (jestjs/jest#2549); it should be fine to switch the check to checking for a string (in fact it's arguably better as it means people could provide their own custom object with atestfunction 🤷)