Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-large-snapshots): avoid instanceof RegExp check for ESLint v9 compatibility #1542

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 29, 2024

Cherry picked from #1534 - it seems that globals are different in ESLint v9 resulting in the same issue with instanceof that Jest has (jestjs/jest#2549); it should be fine to switch the check to checking for a string (in fact it's arguably better as it means people could provide their own custom object with a test function 🤷)

@G-Rath G-Rath marked this pull request as ready for review March 29, 2024 22:19
@G-Rath G-Rath merged commit af4a9c9 into next Mar 29, 2024
28 checks passed
@G-Rath G-Rath deleted the fix-no-large-snapshots branch March 29, 2024 22:19
github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
# [28.0.0-next.6](v28.0.0-next.5...v28.0.0-next.6) (2024-03-29)

### Bug Fixes

* **no-large-snapshots:** avoid `instanceof RegExp` check for ESLint v9 compatibility ([#1542](#1542)) ([af4a9c9](af4a9c9))
Copy link

🎉 This PR is included in version 28.0.0-next.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Apr 6, 2024
# [28.0.0](v27.9.0...v28.0.0) (2024-04-06)

### Bug Fixes

* allow ESLint 9 as peer dependency ([#1547](#1547)) ([3c5e167](3c5e167))
* drop support for Node 19 ([#1548](#1548)) ([c87e388](c87e388))
* **no-large-snapshots:** avoid `instanceof RegExp` check for ESLint v9 compatibility ([#1542](#1542)) ([af4a9c9](af4a9c9))

### Features

* drop support for `@typescript-eslint/eslint-plugin` v5 ([#1530](#1530)) ([150e355](150e355))
* drop support for Node v14 ([#1527](#1527)) ([df5e580](df5e580))
* remove `no-if` rule ([#1528](#1528)) ([f976fc8](f976fc8))
* remove `snapshot` processor and `flat/snapshot` config ([#1532](#1532)) ([98087f9](98087f9))
* upgrade `@typescript-eslint/utils` to v6 ([#1508](#1508)) ([dc6e8cd](dc6e8cd))

### BREAKING CHANGES

* Node v19 is no longer supported
* removed unneeded `snapshot` processor and `flat/snapshot` config
* dropped support for `@typescript-eslint/eslint-plugin` v5
* dropped support for Node v14
* removed `no-if` in favor of `no-conditional-in-test`
Copy link

github-actions bot commented Apr 6, 2024

🎉 This PR is included in version 28.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant