fix: allow ESLint 9 as peer dependency #1547
Conversation
|
Beat me to it 😁 |
|
🎉 This PR is included in version 28.0.0-next.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [28.0.0](v27.9.0...v28.0.0) (2024-04-06) ### Bug Fixes * allow ESLint 9 as peer dependency ([#1547](#1547)) ([3c5e167](3c5e167)) * drop support for Node 19 ([#1548](#1548)) ([c87e388](c87e388)) * **no-large-snapshots:** avoid `instanceof RegExp` check for ESLint v9 compatibility ([#1542](#1542)) ([af4a9c9](af4a9c9)) ### Features * drop support for `@typescript-eslint/eslint-plugin` v5 ([#1530](#1530)) ([150e355](150e355)) * drop support for Node v14 ([#1527](#1527)) ([df5e580](df5e580)) * remove `no-if` rule ([#1528](#1528)) ([f976fc8](f976fc8)) * remove `snapshot` processor and `flat/snapshot` config ([#1532](#1532)) ([98087f9](98087f9)) * upgrade `@typescript-eslint/utils` to v6 ([#1508](#1508)) ([dc6e8cd](dc6e8cd)) ### BREAKING CHANGES * Node v19 is no longer supported * removed unneeded `snapshot` processor and `flat/snapshot` config * dropped support for `@typescript-eslint/eslint-plugin` v5 * dropped support for Node v14 * removed `no-if` in favor of `no-conditional-in-test`
|
🎉 This PR is included in version 28.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| @@ -86,7 +86,7 @@ | |||
| "babel-jest": "^29.0.0", | |||
| "babel-plugin-replace-ts-export-assignment": "^0.0.2", | |||
| "dedent": "^1.5.0", | |||
| "eslint": "^7.0.0 || ^8.0.0", | |||
| "eslint": "^7.0.0 || ^8.0.0 || ^9.0.0", | |||
There was a problem hiding this comment.
@SimenB is there some Yarn trick I don't know about to actually select the version to use locally without a git change?
I'm finding that v9 is being installed, which completely breaks my IDE and tests - alternatively, could we remove v9 from this list? CI was running fine with installing next without this so I don't know quite why we need it 😅
There was a problem hiding this comment.
yeah, we don't really need it here (which causes renovate to install v9)
|
I am getting this warning: Is it related? |
|
@anthony0030 typescript-eslint/typescript-eslint#8211 (we will probably need to update to v7 whenever that is actually fixed) Things should work fine even with the warning, tho. |
|
@SimenB thankyou for the info 😃 |
No description provided.