Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ESLint 7.x #568

Closed
Tracked by #190
MichaelDeBoey opened this issue May 8, 2020 · 5 comments · Fixed by #572
Closed
Tracked by #190

Support ESLint 7.x #568

MichaelDeBoey opened this issue May 8, 2020 · 5 comments · Fixed by #572
Labels
released

Comments

@MichaelDeBoey
Copy link
Contributor

ESLint v7.0.0 is released 🎉

It would be awesome to have official ESLint 7 support. 👊
I'm happy to help where I can of course 🙂
@MichaelDeBoey MichaelDeBoey mentioned this issue May 8, 2020
Merged
26 tasks
@G-Rath
Copy link
Collaborator

G-Rath commented May 9, 2020

That's perfect timing actually: this will require a new major as it drops support for node 8, which Jest 26 did as well.

@SimenB I've just merged #564 - is there anything else we want before cutting a new major?

@MichaelDeBoey MichaelDeBoey mentioned this issue May 9, 2020
Closed
16 tasks
@G-Rath
Copy link
Collaborator

G-Rath commented May 9, 2020

Actually @MichaelDeBoey I just realised we already support eslint@7 since we have a peer dependency on >= 6 for eslint.

If there's a specific problem you're having let me know, but other I'll close this off since it's already supported :)

@MichaelDeBoey
Copy link
Contributor Author

According to peerDependencies, we indeed do, but it's not tested (yet) so not really officially supported

@G-Rath G-Rath mentioned this issue May 9, 2020
Merged
@G-Rath
Copy link
Collaborator

G-Rath commented May 9, 2020 •
edited
Loading

I've adjusted our test suite to run against eslint 7, so you can consider it officially supported now :)

(on an aside: I'm very much liking github actions 😄)

@github-actions
Copy link

🎉 This issue has been resolved in version 23.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced May 17, 2020
Merged
Merged
Merged
Merged
@MichaelDeBoey MichaelDeBoey mentioned this issue Sep 4, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run tests against eslint@7 jest-community/eslint-plugin-jest
feat: Support ESLint 7.x
2 participants
@G-Rath @MichaelDeBoey