Add prefer-to-be-null rule #10
Conversation
rules/prefer_to_be_null.js
Outdated
| const propertyName = parentProperty.name; | ||
| const argument = node.parent.parent.arguments[0]; | ||
|
|
||
| if (propertyName === 'toBe' && argument.value === null) { |
xfumihiro
force-pushed
the
prefer-to-be-null
branch
from
0020143
to
faf058a
Compare
| ruleTester.run('prefer_to_be_null', rules['prefer-to-be-null'], { | ||
| valid: ['expect(null).toBeNull();'], | ||
|
|
||
| invalid: [ |
There was a problem hiding this comment.
Could you add a test for toBeEqual here (and the other PRs)?
xfumihiro
force-pushed
the
prefer-to-be-null
branch
from
faf058a
to
dab0306
Compare
README.md
Outdated
| @@ -32,6 +32,7 @@ Then configure the rules you want to use under the rules section. | |||
| "jest/no-disabled-tests": "warn", | |||
| "jest/no-focused-tests": "error", | |||
| "jest/no-identical-title": "error", | |||
| "jest/prefer-to-be-null": "warn", | |||
There was a problem hiding this comment.
IMO this should be off by default, otherwise it's a breaking change
There was a problem hiding this comment.
Why so?
Same for all others?
There was a problem hiding this comment.
If I use toBe(null) somewhere in my code, and have activated the recommended rules, my build is potentially broken in a feature release (or we can do a major, but I don't think that's necessary).
other open PRs yes
There was a problem hiding this comment.
It's a "warn" level, so by default it should not fail the lint command.
There was a problem hiding this comment.
Just removed all warnings. 😓
Should redo?
There was a problem hiding this comment.
How about moving forward on this at the moment?
There was a problem hiding this comment.
Oh, sorry! yeah, let's just roll with it
|
I never got an email that you pushed, sorry about being slow here! |
|
No worries! |
xfumihiro
force-pushed
the
prefer-to-be-null
branch
from
dab0306
to
ec92314
Compare
No description provided.