-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(consistent-test-it): false positives inside describe.each #782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers!
The title merged in to be greater than 100 chars - I've forcely re-worded it on main to be |
ugh seems the forces are coming together to prevent this one from being released:
|
@SimenB I think this is because of #781 - in the past it doesn't look like husky/commitlint would run against the commits made by semantic-release. |
## [24.1.8](v24.1.7...v24.1.8) (2021-03-07) ### Bug Fixes * **consistent-test-it:** support `it.each` in `describe.each` ([#782](#782)) ([0014da0](0014da0))
I think this PR added false positive ESLing errors where
test
insidedescribe.each
was actually thought to beit
insidedescribe.each
. (and the other way around) - see failing tests.The bug exists on the last release (
24.1.7
) but was not present before.The fix was in the
isDescribe
andisTestCase
helpers, which ignored the.each
version with templates.