chore(deps): lock file maintenance

[renovate]

This PR contains the following updates:

Update	Change
lockFileMaintenance	All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.

---

Configuration

📅 Schedule: "before 5am on monday" (UTC).

🚦 Automerge: Enabled.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, check this box.

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[SimenB]

@G-Rath typescript is unhappy here. Any ideas?

[G-Rath]

I'm on mobile so can't actually see the errors 😅

If you want to assign this to me, I can take a look tomorrow morning

[SimenB]

I manually refreshed the lockfile on main, just holding back @typescript-eslint/* and it seems happy, so there's some change there.

Screenshot of errors:

[SimenB]

Semi-related - we should move the typecheck into its own run instead of doing it in every single one

[G-Rath]

@SimenB I thought jest v27 fixed this:

 FAIL  src/rules/__tests__/valid-expect-in-promise.test.ts
  ● Test suite failed to run

    TypeError: Converting circular structure to JSON
        --> starting at object with constructor 'Node'
        |     property 'object' -> object with constructor 'Node'
        --- property 'parent' closes the circle
        at stringify (<anonymous>)

      at messageParent (node_modules/jest-worker/build/workers/messageParent.js:42:19)

Either way, I would really love to get this resolved: is there anyway I can help?

(in saying that, actually iirc it was fixed but then you had to revert it for a good reason that I can't remember)

[SimenB]

(in saying that, actually iirc it was fixed but then you had to revert it for a good reason that I can't remember)

jestjs/jest#10577 (comment)

I haven't got the energy to tackle this one myself at the moment, but if you're up for it I think we essentially wanna add an API to jest-worker that allows us to plug in custom (de)serializers. Then jest-runner could inject one using flatted or whatever to properly serialize circular objects

[SimenB]

should this be a fix (i.e. released as a patch?)?

[G-Rath]

Na, this is just a refactor as it doesn't actually change the behaviour: since we pick these two items out of the array only to then make a new array out of them which we pass through to a function.

So .slice(0, 2) should be functionally equivalent as that selects the first two items in the node.arguments array.

[SimenB]

@G-Rath haha, renovate squashed away your commit, sorry! 😅 hopefuully just a cherry-pick away 🙂

[G-Rath]

@SimenB found while hacking around in jest-runner & co 😅:

[SimenB]

Yeah, got tired of months and months on pre-release...

[G-Rath]

It should be somewhat easy to setup a lint rule for that - something like TODO(<major number>): that meant you could then enable that rule manually when you wanted to find all the todos that were planned for a specific major.

[SimenB]

I knew about it, just didn't bother with it 😃 Could've changed the comment I guess

[G-Rath]

and now I can't seem to reproduce it :/

 FAIL   test  src/rules/__tests__/valid-describe.test.ts
  ● valid-describe › valid › x();

    TypeError: Cannot read property 'type' of undefined
    Occurred while linting <input>:1

      42 |         // throw new Error('oh noes!');
      43 |         if (
    > 44 |           node.arguments[1].type === AST_NODE_TYPES.CallExpression &&
         |                             ^
      45 |           !isDescribeCall(node)
      46 |         ) {
      47 |           return;

      at CallExpression (src/rules/valid-describe.ts:44:29)
          at Array.forEach (<anonymous>)
          at Array.forEach (<anonymous>)

[github-actions]

🎉 This PR is included in version 24.3.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀