Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make more efficient #848

Merged
merged 3 commits into from
May 25, 2021
Merged

ci: make more efficient #848

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79be500
ci: do typecheck in its own job
G-Rath May 25, 2021
714440e
ci: do prettier check in its own job
G-Rath May 25, 2021
1c719ea
ci: don't fetch everything on checkout on jobs that don't need it
G-Rath May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 45 additions & 13 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,50 @@ jobs:
YARN_ENABLE_SCRIPTS: false
run: yarn --immutable

prettier:
needs: prepare-yarn-cache
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
- uses: actions/cache@v2
with:
path: ${{ steps.yarn-cache.outputs.dir }}
key: yarn2-${{ hashFiles('yarn.lock') }}
restore-keys: |
yarn2-
- uses: actions/setup-node@v2.1.5
with:
node-version: 14.x
- name: install
run: yarn
- name: run prettier
run: yarn prettier:check

typecheck:
needs: prepare-yarn-cache
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
- uses: actions/cache@v2
with:
path: ${{ steps.yarn-cache.outputs.dir }}
key: yarn2-${{ hashFiles('yarn.lock') }}
restore-keys: |
yarn2-
- uses: actions/setup-node@v2.1.5
with:
node-version: 14.x
- name: install
run: yarn
- name: run typecheck
run: yarn typecheck

test-node:
name:
# prettier-ignore
Expand All @@ -54,8 +98,6 @@ jobs:

steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
Expand All @@ -73,10 +115,6 @@ jobs:
run: |
yarn
yarn add --dev eslint@${{matrix.eslint-version }}
- name: run prettier
run: yarn prettier:check
- name: run typecheck
run: yarn typecheck
- name: run tests
# only collect coverage on eslint versions that support the suggestions api
run: yarn test --coverage ${{ matrix.eslint-version >= 6 }}
Expand Down Expand Up @@ -109,10 +147,6 @@ jobs:
node-version: 14.x
- name: install
run: yarn
- name: run prettier
run: yarn prettier:check
- name: run typecheck
run: yarn typecheck
- name: run tests
run: yarn test --coverage
env:
Expand All @@ -124,8 +158,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
Expand Down Expand Up @@ -153,7 +185,7 @@ jobs:
# prettier-ignore
${{ github.event_name == 'push' && github.event.ref == 'refs/heads/main' }}
name: Release new version
needs: [test-node, test-os]
needs: [prettier, typecheck, test-node, test-os]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down