Add prefer-to-be-undefined rule #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
requested changes
Nov 10, 2017
rules/prefer_to_be_undefined.js
Outdated
| const propertyName = parentProperty.name; | ||
| const argument = node.parent.parent.arguments[0]; | ||
|
|
||
| if (propertyName === 'toBe' && argument.value === undefined) { |
There was a problem hiding this comment.
toEqual as well
Should probably pull alot of this shared code out into a util
xfumihiro
force-pushed
the
prefer-to-be-undefined
branch
2 times, most recently
from
4e4213a
to
c423b1a
Compare
xfumihiro
force-pushed
the
prefer-to-be-undefined
branch
from
c423b1a
to
0e2f7f8
Compare
SimenB
force-pushed
the
prefer-to-be-undefined
branch
from
3f71f72
to
0e2f7f8
Compare
SimenB
force-pushed
the
prefer-to-be-undefined
branch
from
0e2f7f8
to
01ba9d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.