fix(valid-describe): add check for empty arguments #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Mar 1, 2018
| @@ -11,6 +11,7 @@ const ruleTester = new RuleTester({ | |||
|
|
|||
| ruleTester.run('valid-describe', rule, { | |||
| valid: [ | |||
| 'describe()', | |||
There was a problem hiding this comment.
An empty describe isn't valid - could you make it be a linting error instead?
There was a problem hiding this comment.
just a
if (node.arguments.length < 2) {
context.report({
message: '`describe` requires 2 arguments',
loc: paramsLocation(node.arguments),
});
return;
}or something similar
SimenB
approved these changes
Mar 13, 2018
|
🎉 This PR is included in version 21.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@SimenB Sorry about that, ended up rather busy. Thanks for following through! |
This was referenced Mar 14, 2018
|
No worries 🙂 Seemed like a pretty critical error to land, and your PR was basically there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #93.