extend toBeEmpty to support Map, Set, and any other iterable #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Teach toBeEmpty how to test for emptiness of any Iterable.
Why
Implements #158. Adds support for testing emptiness of Map and Set, amongst others.
Notes
@mattphillips suggested implementing this using
[...value].length === 0
. That would have been a neat, terse implementation but would not have worked for non-terminating iterables (which admittedly is a pretty obscure edge case). A more plausible advantage of not using the destructuring approach is that we avoid unecessary evaluation of potentially large/expensive iterables - we only need to go as far as yielding one value. Not really a huge deal either way, but it seemed a good tradeoff to make the implementation a bit bigger in exchange for supporting weird custom iterables.Housekeeping
yarn contributor
)