Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toBeSymbol matcher #217

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented May 24, 2019

What

Added .toBeSymbol matcher.

Why

Sometimes you want to test if something is a Symbol.

Notes

Implementation copied from .toBeFunction.

I would usually open an issue before submitting a PR, but as this is pretty simple stuff, I've not bothered with an issue. If I've missed anything, please let me know and I'll amend this PR accordingly.

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant

@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #217 (5e9f9e9) into main (c4961cd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #217   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          121       123    +2     
  Lines          750       761   +11     
  Branches       110       111    +1     
=========================================
+ Hits           750       761   +11     
Impacted Files Coverage Δ
src/matchers/index.js 100.00% <100.00%> (ø)
src/matchers/toBeSymbol/index.js 100.00% <100.00%> (ø)
src/matchers/toBeSymbol/predicate.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4961cd...5e9f9e9. Read the comment docs.

@overlookmotel
Copy link
Contributor Author

Hellooooo! Anyone have an interest in reviewing this and possibly merging it?

@overlookmotel overlookmotel mentioned this pull request Feb 15, 2020
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit adb82b8 into jest-community:main Oct 11, 2021
@overlookmotel
Copy link
Contributor Author

Thanks for merging. I thought this repo was dead!

@overlookmotel overlookmotel deleted the to-be-symbol branch December 27, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants