Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'toBeBetween', 'toBeAfterOrEqualTo' and 'toBeBeforeOrEqualTo' matchers. #229

Merged
merged 7 commits into from
Oct 11, 2021

Conversation

hansal7014
Copy link
Contributor

What changes are being made? (feature/bug)

Adding 'toBeBetween', 'toBeAfterOrEqualTo' and 'toBeBeforeOrEqualTo' date matchers.

Why are these changes necessary? Link any related issues

New date matchers are being added as requested in issue #117

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant

Adding 'toBeBetween', 'toBeAfterOrEqualTo' and 'toBeBeforeOrEqualTo' type definitions to index.d.ts
Adding documentation for 'toBeBetween', 'toBeAfterOrEqualTo' and 'toBeBeforeOrEqualTo' matchers.
@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #229 (3c197da) into main (a2904bd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          126       132    +6     
  Lines          744       780   +36     
  Branches       126       130    +4     
=========================================
+ Hits           744       780   +36     
Impacted Files Coverage Δ
src/matchers/toBeAfterOrEqualTo/index.js 100.00% <100.00%> (ø)
src/matchers/toBeAfterOrEqualTo/predicate.js 100.00% <100.00%> (ø)
src/matchers/toBeBeforeOrEqualTo/index.js 100.00% <100.00%> (ø)
src/matchers/toBeBeforeOrEqualTo/predicate.js 100.00% <100.00%> (ø)
src/matchers/toBeBetween/index.js 100.00% <100.00%> (ø)
src/matchers/toBeBetween/predicate.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2904bd...3c197da. Read the comment docs.

@hansal7014
Copy link
Contributor Author

Hi @mattphillips,
Could you please review my pull work and merge it or provide feedback as needed.
Thanks.

@thiagodp
Copy link
Contributor

It would be great to have these mathers available 😉

@SimenB SimenB linked an issue Oct 11, 2021 that may be closed by this pull request
@SimenB SimenB merged commit b7e2332 into jest-community:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date API Proposal
4 participants