Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis with GitHub Actions #326

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Replace Travis with GitHub Actions #326

merged 2 commits into from
Jun 23, 2021

Conversation

keeganwitt
Copy link
Collaborator

What

Switching from Travis to GitHub Actions.

Why

Travis changed their pricing model, which allocates 10,000 credits/minutes for open source projects. Once those credits are consumed, you must repeat the process to request more credits.

Notes

  • GitHub Free offers 2,000 credits per month, but there is no total cap and no renewal process is needed. If we have spikey months, we may not wish to proceed with this change.
  • Codecov authentication isn't configured yet because I didn't have that information.

@SimenB
Copy link
Member

SimenB commented Jun 23, 2021

GH actions are free for open source (public repos), no limits

image

runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we currently support node 8. I'm down with just supporting the current LTSes, tho 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I didn't realize that. I like the idea of supporting only current LTS, but what does Jest itself officially support? Or is that what you meant by "we"?

"babel-cli": "^6.26.0",
"babel-core": "^6.26.0",
"babel-eslint": "^8.0.1",
"babel-jest": "^23.0.1",
"babel-jest": "^24.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I bumped Jest to 24 so I could use --color, I also bumped this dependency. Both are dev dependencies.

@@ -99,7 +99,7 @@
"babel-plugin-transform-es2015-modules-commonjs",
"transform-object-rest-spread",
"transform-async-to-generator",
"babel-jest-assertions",
"./node_modules/babel-jest-assertions",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"./node_modules/babel-jest-assertions",
"module:babel-jest-assertions",

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that was a Babel 7 syntax? If I'm mistaken, then yea, I prefer that (I did it in the Babel 7 PR already)

node-version: ${{ matrix.node-version }}
- run: yarn install
- run: yarn lint
- run: yarn test:coverage
Copy link
Member

@SimenB SimenB Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be enough to add https://github.com/codecov/codecov-action, and that'll use GH_TOKEN or something

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keeganwitt
Copy link
Collaborator Author

GH actions are free for open source (public repos), no limits

Ah, I thought public repos fell under the "free" tier of 2,000 minutes per month. But now I see what you're saying

GitHub Actions usage is free for both public repositories and self-hosted runners.

Even better!

@rickhanlonii rickhanlonii merged commit eec0323 into jest-community:master Jun 23, 2021
@keeganwitt keeganwitt deleted the upstream/keeganwitt/gh_actions branch June 23, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants