Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing types for toPartiallyContain #392

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

idan-at
Copy link
Contributor

@idan-at idan-at commented Dec 8, 2021

What

Missing types for a newly added matcher.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #392 (802084c) into main (5083e49) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #392   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          137       137           
  Lines          843       843           
  Branches       143       143           
=========================================
  Hits           843       843           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5083e49...802084c. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface Expect {
as well, no?

@idan-at
Copy link
Contributor Author

idan-at commented Dec 9, 2021

as well, no?

@SimenB of course - 802084c

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 52bad37 into jest-community:main Dec 9, 2021
@Smrtnyk
Copy link

Smrtnyk commented Dec 16, 2021

any chance we can have a release?
I want to use this matcher but ts complains and I don't feel like creating my own type if release is coming soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants