Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade Jest #80

Closed
wants to merge 1 commit into from
Closed

fix: upgrade Jest #80

wants to merge 1 commit into from

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 25, 2019

No description provided.

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no lockfile?

@SimenB
Copy link
Member Author

SimenB commented Jan 25, 2019

I made this change on GitHub. This repo doesn't seem to have a lockfile, though

@palmerj3
Copy link
Collaborator

@SimenB I can take a look further at this. Can probably remove the jest 22 check at this point if that's breaking things.

Is this urgent or needed for a release?

@SimenB
Copy link
Member Author

SimenB commented Jan 25, 2019

Nah, just noisy in lockfiles after upgrading since jest-config pulls in babel-core@6

@siemiatj
Copy link

+1 . I had to disable junit for now as it's sucking in babel-core 6.x :/

@SimenB
Copy link
Member Author

SimenB commented Jan 28, 2019

#81

@SimenB SimenB closed this Jan 28, 2019
@SimenB SimenB deleted the SimenB-patch-1 branch January 28, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants