Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to yarn berry #24

Merged
merged 2 commits into from
Oct 17, 2021
Merged

chore: migrate to yarn berry #24

merged 2 commits into from
Oct 17, 2021

Conversation

mrazauskas
Copy link
Contributor

@mrazauskas mrazauskas commented Oct 17, 2021

What if yarn-patched tsd would be used instead of mlh-tsd? Does it cause any trouble?

The patch is based on the PR I have send to tsd. The change is minimal and it is covered by a test (I mean, my branch includes passing test). This library also has e2e tests. The result is predictable. Or?

This solution would allow to uncomment type tests in jest repo. And would unblock jestjs/jest#11142 too.

@SimenB What you think?

@mrazauskas mrazauskas changed the title feat: use patched tsd instead of mhl-tsd feat: use patched tsd instead of mlh-tsd Oct 17, 2021
@SimenB
Copy link
Member

SimenB commented Oct 17, 2021

A patch only applies locally, it's not applied to for consumers. So we'd need to use your fork instead of mlh-tsd.

We can update to yarn v2 separately, tho 🙂

@mrazauskas
Copy link
Contributor Author

Meh.. I felt there is some trick.

Ok. I will refactor this to update Yarn. Let’s wait for tsd folks. Of course, my fork is a good plan B.

@mrazauskas mrazauskas changed the title feat: use patched tsd instead of mlh-tsd chore: migrate to yarn berry Oct 17, 2021
.gitignore Outdated Show resolved Hide resolved
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit ada19b4 into jest-community:main Oct 17, 2021
@mrazauskas mrazauskas deleted the feat-use-patched-tsd branch October 17, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants