-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gutter icons are missing vscode 1.14.2 #130
Comments
i am using typescript with jest pre-processor - is that supported @orta ? |
TS + Jest is my setup everywhere 👍. I'd recommend looking at the regex to register whether a file should be considered a test file somewhere |
hi, my test are running perfectly and reflected in the bottom even when they break. it is just the gutter icons that don't show up. everything else is working as expected. |
Does anyone have a sample repo we can look at? My guess is that it has something to do with the jest config being used. |
regular setup... just pointed to jest to the files. not even sure if there is a dedicated jest file other than package json scripts |
I'm seeing this in the repo here. macOS 10.13, Node v7.8.0. |
Same here, it seems to be running all tests correctly. However, I am not receiving the gutters icons (green and red circles) and InlineErrorMessages do not seem to be inserted into the file, as is shown in the gif on the front page. macOS 10.12, Node 8.1.2, Jest 21.1.0, Typescript 2.5.2. |
Same for me since updating to Jest 21. I think it's caused by changed output of |
Downgrading to Jest v20 and upgrading to v21 again somehow fixed this for me in our monorepo setup. |
There was an update last night to the extension which should help this ( #146 ) |
Calling this fixed |
Just stopped working for me agian. Errors are showing up in 'Problems' panel, Jest is running al tests as expected AFAICT. Inline error messages in comments and gutter icons are not showing up however. Could this have to do with yesterdays update of VS Code? |
I have the same problem, in one project it's working well but in another one not 😕 |
I was having this issue as well. Through trial and error I was able to determine that for me the missing icons seemed to be due to me disabling the Jest extension. Once I re-eneabled the Jest extension (the one maintained by Orta Therox , Sean Poulter , Vincent Voyer & ConnectDotz ), the icons came back. |
I have a repo that consistently reproduces this problem for just one file, but not another: phoenixeliot/line-puzzle@fa953e9 The icons don't appear in Board.test.ts, but do appear in Area.test.ts. The tests in Board.test.ts do get red underlines for the lines that are related to test failures, though, so the tests are running. EDIT: Bah, this isn't reproing if I clone my own repo into a new folder. I'm going to see if I can find any state data from VS Code or something. EDIT2: When I restart VS Code, the correct behavior comes back briefly but goes away as soon as the tests finish running. I see the green play button icons, but no spinning icons or result icons. |
Is there somewhere I can get debug logs or something for this? I turned on "debug mode" in the Jest extension settings, but that didn't add any extra logs I could find. This problem occurs regardless of any settings I have turned on or off in my VS Code settings. |
OK, I think I've narrowed it down. This was probably introduced when I memento/workbench.parts.editor
Note in particular that two of the editors have both a When I replicate this same pattern to Area.test.ts, I get the exact same symptoms. It seems some part of the Jest extension is doing a case-sensitive filename check based on the resourceJSON filename, while other parts aren't. |
This was involved enough that I made a new ticket: #810 |
Environment
node -v
: 6.9.1npm -v
: 3+Operating system: windows 10
Steps to Reproduce
install extension
run - npm test or setup lanuch.json or "start jest runner"
Expected Behavior
lines of code tested are marked with green icons at left side gutter if they pass. red if they fail
Actual Behavior
no icons at the gutter. only status below in the bottom of the window. that says pass/fail
all setting seem to be true
The text was updated successfully, but these errors were encountered: