improve failure reporting for the whole project #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectdotz
changed the title
orta
approved these changes
Oct 1, 2017
| status.success() | ||
| } else { | ||
| status.failed() | ||
| status.failed(` (${failedFileCount} test suite${failedFileCount > 1 ? 's' : ''} failed)`) |
| import { TestFileAssertionStatus } from 'jest-editor-support' | ||
| import { TestReconciliationState } from './TestReconciliationState' | ||
|
|
||
| export function updateDiagnositics(testResults: TestFileAssertionStatus[], diagnostics: vscode.DiagnosticCollection) { |
There was a problem hiding this comment.
updateDiagnositics, typo: updateDiagnostics
There was a problem hiding this comment.
Oops, indeed... Looks like you already merged it, I will submit a new PR then
| export function failedSuiteCount(diagnostics: vscode.DiagnosticCollection): number { | ||
| let sum = 0 | ||
| diagnostics.forEach(() => sum++) | ||
| return sum |
There was a problem hiding this comment.
interesting, I didn't know reduce was not a part of the JS core library
There was a problem hiding this comment.
Array.prototype.reduce() is indeed part of JS core, unfortunately diagnostics is a vscode.DiagnosticCollection, which only exposes forEach() iterator... I know it looked stupid but we have no choice here...
| setTimeout(() => initial(), 2000) | ||
| } | ||
|
|
||
| function updateStatus(message: string) { | ||
| function updateStatus(message: string, details?: string) { |
|
Published 21.3.0-alpha.eff7a1cf for you guys. |
|
ohhh yeahhh, thanks! |
This was referenced Oct 2, 2017
legend1202
pushed a commit
to legend1202/vscode-jest
that referenced
this pull request
Jun 18, 2023
improve failure reporting for the whole project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed the issues discussed in #129, mainly to make managing tests easier (especially for monorepo projects) by providing the test state for the "whole-project" in addition to the "changed", plus a few usability/stability enhancement.
change outline
Note
Follow up