Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual-folder #1035

Merged
merged 12 commits into from
Jun 19, 2023
Merged

Virtual-folder #1035

merged 12 commits into from
Jun 19, 2023

Conversation

connectdotz
Copy link
Collaborator

@connectdotz connectdotz commented Jun 17, 2023

We have come a full circle on this issue - supporting multiple jest configs for a given workspace. This is common for monorepo projects and projects with multiple test environments, such as unit and integration tests. We implemented monorepo support with vscode multi-root workspaces a few years ago. However, this fell short of addressing multi-test-environment that share the same code base (folder).

This PR addresses this gap by introducing the concept of virtual folders. A virtual folder defines a jest runtime environment, customizable with all resource level settings, such as jestCommanLine, rootPath. Multiple virtual folders can reside in any given vscode workspace folder via jest.virtualFolders. See details documented in the README.md file.

The code change outline:

  • expand the JestExt to be workspace "agnostic", i.e. it can work with either the actual vscode.WorkspaceFolder or virtualFolder.
  • update workspace-manager, extension-manager, StatusBar, CoverageCodeLensProvider etc to work with virtual folders.
  • update DebugConfigurationProvider to append the folder name to the generated configuration names.
  • adjust the setup wizard to work with virtual folders. (except the monorepo setup, which will ignore virtual folders)
  • a few refactoring and code organization change.
  • tests adjustment accordingly.

resolve #870
resolve #428

@coveralls
Copy link

coveralls commented Jun 17, 2023

Pull Request Test Coverage Report for Build 5307024458

  • 392 of 392 (100.0%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 97.771%

Totals Coverage Status
Change from base Build 5262287914: 0.04%
Covered Lines: 3543
Relevant Lines: 3563

💛 - Coveralls

@connectdotz connectdotz marked this pull request as ready for review June 19, 2023 02:09
@connectdotz connectdotz merged commit 1867bde into jest-community:master Jun 19, 2023
@connectdotz connectdotz deleted the virtual-folder branch June 19, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants