fix: include rootPath of virtual folders in testPathPattern value #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akwodkiewicz
force-pushed
the
fix/virtual-folder-path-patterns
branch
from
49bf971 to
1ab486c
Compare
akwodkiewicz
changed the title
Pull Request Test Coverage Report for Build 6531456082
💛 - Coveralls |
connectdotz
requested changes
Oct 14, 2023
There was a problem hiding this comment.
@akwodkiewicz, Thanks for the PR! The change looks good, but let's create some tests to safeguard this use case.
|
Sure thing. I wanted to ask for help in how to write them, but I think I'll be able to pull off a unit test for |
This commit's purpose is to separate the code style changes from the actual modifications (new tests) added in the next commit.
akwodkiewicz
force-pushed
the
fix/virtual-folder-path-patterns
branch
from
5079dd8 to
7c93a19
Compare
|
The PR is ready for another review |
connectdotz
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1079 by using:
VirtualWorkspaceFolder.effectiveUri(including virtual's folderrootPath)instead of:
VirtualWorkspaceFolder.uri(which points to the actual workspace folder)when creating test items from folders in
WorkspaceRoot