Adjust test result indicator for colorblind people #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectdotz
reviewed
Oct 13, 2019
|
Good idea. Please check if this is what you are looking for. |
|
the checkmark is a bit small, comparing to the green dot, maybe I am just not used to it yet... lets both try it for a few days to decide... |
|
it's been a few days, anybody has any objection to merging this PR? |
connectdotz
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
This is a simple UI change. The "pass" indicator is a bit small for me, but it's quite subjective anyway. Overall, I think it improves accessibility; and a refreshing UI could be a plus too. So let's give it a try!
Thanks @jmarceli
|
Thanks so much for doing this! |
Closed
legend1202
pushed a commit
to legend1202/vscode-jest
that referenced
this pull request
Jun 18, 2023
* Adjust test results for colorblind people * Add checkmark symbol for passed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #500 it might be beneficial to change the failing test icon to easily distinguish it from the success status without any color information.