Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup wizard beta #655

Merged
merged 11 commits into from
Apr 4, 2021
Merged

Conversation

connectdotz
Copy link
Collaborator

resolve #590

Summary

  • created a new "vscode-jest.setup-extension" command and wire it with error message panel when jest process failed or jest debug config is missing
  • also added a "setup-wizard.md" file for more in-depth help about this process.
  • it also faciliate migration from jest.pathToJest to jest.jestCommandLine
  • upgrade our vscode engine from 1.23 to 1.45 (April 2020) as we are falling behind on quite a few API changes.

The UI is not "pretty" but hopefully is simple enough that it is clear what we are trying to do. I did end up adapt the jestCommandLine into the debug config, which should resolve some confusion about why jest.pathToConfig not in debug config. But it did introduce a bit of tricky regexp split logic, something to watch out for...

Unit testing with UI is a bit messy, the test files are often larger than the source...

Need Help

I have tested it on mac, would love to have more people testing it on windows and other frameworks to make sure the wizard did not do anything stupid and that it is easy to customize for the use cases that we could not automate today, such as pnp...

@coveralls
Copy link

coveralls commented Jan 30, 2021

Pull Request Test Coverage Report for Build 907

  • 379 of 390 (97.18%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 94.031%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/setup-wizard/start-wizard.ts 63 64 98.44%
src/setup-wizard/tasks/setup-jest-cmdline.ts 62 64 96.88%
src/setup-wizard/tasks/setup-jest-debug.ts 71 73 97.26%
src/setup-wizard/wizard-helper.ts 149 155 96.13%
Totals Coverage Status
Change from base Build 906: -0.05%
Covered Lines: 1928
Relevant Lines: 2016

💛 - Coveralls

@connectdotz connectdotz requested a review from stephtr February 1, 2021 16:27
@connectdotz connectdotz mentioned this pull request Feb 1, 2021
15 tasks
@connectdotz connectdotz merged commit adb9048 into jest-community:master Apr 4, 2021
@connectdotz connectdotz deleted the setup-wizard branch April 4, 2021 21:03
legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.0] setup wizard
2 participants