-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup wizard beta #655
Merged
Merged
setup wizard beta #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 907
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #590
Summary
"vscode-jest.setup-extension"
command and wire it with error message panel when jest process failed or jest debug config is missingjest.pathToJest
tojest.jestCommandLine
The UI is not "pretty" but hopefully is simple enough that it is clear what we are trying to do. I did end up adapt the jestCommandLine into the debug config, which should resolve some confusion about why jest.pathToConfig not in debug config. But it did introduce a bit of tricky regexp split logic, something to watch out for...
Unit testing with UI is a bit messy, the test files are often larger than the source...
Need Help
I have tested it on mac, would love to have more people testing it on windows and other frameworks to make sure the wizard did not do anything stupid and that it is easy to customize for the use cases that we could not automate today, such as pnp...