Resolve shell env inheritance issue #874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vscode failed to initialize the process env correctly (only for non-windows platforms), users might see errors during jest run like
This PR adds the ability to execute jest commandLine through a spanwed login shell to avoid dependency on vscode env initialization. By default, we will still be spawning jest process via non-login/non-interactive shell, as it is more efficient. The login-shell execution is a opt-in option right now. Possible future enhancement, if desired, is to utilize the vscode
terminal.integrated.profiles
option to automatically use the same shell as the vscode terminal.jest.shell
to allow LoginShell for non-windows platform, see support spawn process in a login-shell for non-windows platform jest-editor-support#87 for detailsfix #865
fix #867
fix #845
fix #828
fix #833