Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve shell env inheritance issue #874

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

connectdotz
Copy link
Collaborator

When vscode failed to initialize the process env correctly (only for non-windows platforms), users might see errors during jest run like

env: node: No such file or directory

This PR adds the ability to execute jest commandLine through a spanwed login shell to avoid dependency on vscode env initialization. By default, we will still be spawning jest process via non-login/non-interactive shell, as it is more efficient. The login-shell execution is a opt-in option right now. Possible future enhancement, if desired, is to utilize the vscode terminal.integrated.profiles option to automatically use the same shell as the vscode terminal.

fix #865
fix #867
fix #845
fix #828
fix #833

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2416857126

  • 27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.39%

Totals Coverage Status
Change from base Build 2388284105: 0.02%
Covered Lines: 2593
Relevant Lines: 2664

💛 - Coveralls

@connectdotz connectdotz merged commit f55a2b4 into jest-community:master Jun 2, 2022
@connectdotz connectdotz deleted the support-login-shell branch June 2, 2022 20:56
legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
* add ShellLogin support

* upgrade jest-editor-support  and update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants