Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to add the folder to the ignored ones in the popup #896

Merged
merged 8 commits into from
Aug 24, 2022

Conversation

jonnytest1
Copy link
Contributor

@jonnytest1 jonnytest1 commented Aug 18, 2022

with this there will be another option next to "Run Setup Wizard" called "Ignore Folder" which when pressed adds the corresponding workspace fodler directly to the ignored folders in the workspace config

i was thinking about , searching the complete workspace for jest files and not enable it at all or maybe a whitelist but i think its better for the user to get notified when a workspace will not be covered by jest and to consciously decide

@coveralls
Copy link

coveralls commented Aug 23, 2022

Pull Request Test Coverage Report for Build 2915882060

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 95.388%

Totals Coverage Status
Change from base Build 2430869878: -0.003%
Covered Lines: 2604
Relevant Lines: 2675

💛 - Coveralls

@jonnytest1
Copy link
Contributor Author

jonnytest1 commented Aug 23, 2022

thanks :)

local there are test failures on windows btw (unrelated )

image
summary: the supports-color sub- sub packages uses os.release() when on windows to determine color format, with the module mocked this throws though, it doesnt seam relevant to give it a specific version so its jsut an empty string for now (especially since the containing module should only be used for highlighting)

this is btw why i didnt commit with eslint fixes: 😅
image

@jonnytest1
Copy link
Contributor Author

jonnytest1 commented Aug 23, 2022

one more hint : since prettier has a rule for line endings to be LF ones i think changing
* text=auto to * text=false in the .gitattributes files makes more sense 🤔 (its not very fun to develop with completely red files ^^)

Copy link
Collaborator

@connectdotz connectdotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonnytest1 thanks for the PR!

I have a few comments, let me know what you think.

src/JestExt/core.ts Outdated Show resolved Hide resolved
src/JestExt/core.ts Outdated Show resolved Hide resolved
@connectdotz
Copy link
Collaborator

Looks like the test coverage has been reduced. @jonnytest1, do you mind adding some tests for the code change? Much appreciated.

@jonnytest1
Copy link
Contributor Author

oh lol i can scroll the checks :D

Copy link
Collaborator

@connectdotz connectdotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The test coverage dip is all right as new changes are now indeed tested.

There are other issues such as double reporting errors but it is not related to this PR, we will address them in another PR.

@connectdotz connectdotz merged commit 44306d6 into jest-community:master Aug 24, 2022
legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
…-community#896)

* added option to add the folder to the ignored ones in the popup

* fixed formatting

* fixed tests on windows

* use direct reference for workspace folder

* add ignore action for multiple workspace folders

* added test for addFolderToDisabledWorkspaceFolders

* test for exit event flow

* reverted formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants