-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added option to add the folder to the ignored ones in the popup #896
Conversation
Pull Request Test Coverage Report for Build 2915882060
💛 - Coveralls |
one more hint : since prettier has a rule for line endings to be LF ones i think changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonnytest1 thanks for the PR!
I have a few comments, let me know what you think.
Looks like the test coverage has been reduced. @jonnytest1, do you mind adding some tests for the code change? Much appreciated. |
oh lol i can scroll the checks :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The test coverage dip is all right as new changes are now indeed tested.
There are other issues such as double reporting errors but it is not related to this PR, we will address them in another PR.
…-community#896) * added option to add the folder to the ignored ones in the popup * fixed formatting * fixed tests on windows * use direct reference for workspace folder * add ignore action for multiple workspace folders * added test for addFolderToDisabledWorkspaceFolders * test for exit event flow * reverted formatting
with this there will be another option next to "Run Setup Wizard" called "Ignore Folder" which when pressed adds the corresponding workspace fodler directly to the ignored folders in the workspace config
i was thinking about , searching the complete workspace for jest files and not enable it at all or maybe a whitelist but i think its better for the user to get notified when a workspace will not be covered by jest and to consciously decide