Replace path sep for testRegex in should_instrument (#5560)

* Replace path sep for testRegex in should_instrument

so test files don't get instrumented on windows given a pattern like /__tests__/*.js

* move testRegex normalization to jest-config

CHANGELOG.md

@@ -1,5 +1,11 @@
 ## master
 
+### Fixes
+
+* `[jest-runtime]` Align handling of testRegex on Windows between searching for
+ tests and instrumentation checks
+ ([#5560](https://github.com/facebook/jest/pull/5560))
+
 ## jest 22.3.0
 
 ### Fixes

integration-tests/__tests__/coverage_remapping.test.js

@@ -11,15 +11,12 @@
 
 const {readFileSync} = require('fs');
 const path = require('path');
-const SkipOnWindows = require('../../scripts/SkipOnWindows');
 const {cleanup, run} = require('../Utils');
 const runJest = require('../runJest');
 
 const dir = path.resolve(__dirname, '../coverage-remapping');
 const coverageDir = path.join(dir, 'coverage');
 
-SkipOnWindows.suite();
-
 beforeAll(() => {
  cleanup(coverageDir);
 });

packages/jest-cli/src/search_source.js

@@ -17,7 +17,7 @@ import path from 'path';
 import micromatch from 'micromatch';
 import DependencyResolver from 'jest-resolve-dependencies';
 import testPathPatternToRegExp from './test_path_pattern_to_regexp';
-import {escapePathForRegex, replacePathSepForRegex} from 'jest-regex-util';
+import {escapePathForRegex} from 'jest-regex-util';
 
 type SearchResult = {|
  noSCM?: boolean,
@@ -36,8 +36,6 @@ export type TestSelectionConfig = {|
  watch?: boolean,
 |};
 
-const pathToRegex = p => replacePathSepForRegex(p);
-
 const globsToMatcher = (globs: ?Array<Glob>) => {
  if (globs == null || globs.length === 0) {
  return () => true;
@@ -52,7 +50,7 @@ const regexToMatcher = (testRegex: string) => {
  return () => true;
  }
 
- const regex = new RegExp(pathToRegex(testRegex));
+ const regex = new RegExp(testRegex);
  return path => regex.test(path);
 };
 

packages/jest-config/src/normalize.js

@@ -463,6 +463,9 @@ export default function normalize(options: InitialOptions, argv: Argv) {
  options[key],
  );
  break;
+ case 'testRegex':
+ value = options[key] && replacePathSepForRegex(options[key]);
+ break;
  case 'automock':
  case 'bail':
  case 'browser':
@@ -506,7 +509,6 @@ export default function normalize(options: InitialOptions, argv: Argv) {
  case 'testFailureExitCode':
  case 'testLocationInResults':
  case 'testNamePattern':
- case 'testRegex':
  case 'testURL':
  case 'timers':
  case 'useStderr':