Tighten type definition of Module

jestjs · Oct 7, 2017 · 32e302c · 32e302c
1 parent 1705e8b
commit 32e302c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/jest-runtime/src/__tests__/runtime_require_module.test.js b/packages/jest-runtime/src/__tests__/runtime_require_module.test.js
@@ -34,11 +34,11 @@ describe('Runtime requireModule', () => {
         'RegularModule',
       );
       expect(Object.keys(exports.module)).toEqual([
+        'children',
         'exports',
         'filename',
         'id',
         'loaded',
-        'children',
         'parent',
         'paths',
       ]);
@@ -51,11 +51,11 @@ describe('Runtime requireModule', () => {
         'RequireRegularModule',
       );
       expect(Object.keys(exports.parent)).toEqual([
+        'children',
         'exports',
         'filename',
         'id',
         'loaded',
-        'children',
         'parent',
         'paths',
       ]);

diff --git a/packages/jest-runtime/src/index.js b/packages/jest-runtime/src/index.js
@@ -29,14 +29,14 @@ import {run as cilRun} from './cli';
 import {options as cliOptions} from './cli/args';
 
 type Module = {|
-  children?: Array<any>,
+  children: Array<Module>,
   exports: any,
   filename: string,
   id: string,
   loaded: boolean,
   parent?: Module,
   paths?: Array<Path>,
-  require?: Function,
+  require?: (id: string) => any,
 |};
 
 type HasteMapOptions = {|
@@ -313,6 +313,7 @@ class Runtime {
       // circular dependencies that may arise while evaluating the module can
       // be satisfied.
       const localModule: Module = {
+        children: [],
         exports: {},
         filename: modulePath,
         id: modulePath,
@@ -386,6 +387,7 @@ class Runtime {
 
     if (manualMock) {
       const localModule: Module = {
+        children: [],
         exports: {},
         filename: modulePath,
         id: modulePath,