Merge branch 'main' into et/expose-config-in-test-sequencer

.eslintrc.cjs

@@ -591,7 +591,9 @@ module.exports = {
     'wrap-regex': 'off',
     yoda: 'off',
 
+    'unicorn/explicit-length-check': 'error',
     'unicorn/no-negated-condition': 'error',
+    'unicorn/prefer-default-parameters': 'error',
     'unicorn/prefer-includes': 'error',
     'unicorn/template-indent': 'error',
   },

.github/workflows/nightly.yml

@@ -1,4 +1,4 @@
-name: Node CI
+name: Node Nightly CI
 
 on:
   workflow_dispatch:
@@ -41,3 +41,12 @@ jobs:
     needs: prepare-yarn-cache-windows
     with:
       os: windows-latest
+  notify:
+    name: Notify failed build
+    needs: [test-ubuntu, test-macos, test-windows]
+    if: failure()
+    runs-on: ubuntu-latest
+    steps:
+      - uses: jayqi/failed-build-issue-action@v1
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}

packages/expect-utils/src/utils.ts

@@ -60,7 +60,7 @@ export const getPath = (
     propertyPath = pathAsArray(propertyPath);
   }
 
-  if (propertyPath.length) {
+  if (propertyPath.length > 0) {
     const lastProp = propertyPath.length === 1;
     const prop = propertyPath[0];
     const newObject = object[prop];
@@ -482,7 +482,7 @@ export const isError = (value: unknown): value is Error => {
 };
 
 export function emptyObject(obj: unknown): boolean {
-  return obj && typeof obj === 'object' ? !Object.keys(obj).length : false;
+  return obj && typeof obj === 'object' ? Object.keys(obj).length === 0 : false;
 }
 
 const MULTILINE_REGEXP = /[\r\n]/;

packages/expect/__typetests__/expect.test.ts

@@ -174,7 +174,7 @@ const allowOmittingExpected: MatcherFunction = (
   actual: unknown,
   ...expect: Array<unknown>
 ) => {
-  if (expect.length !== 0) {
+  if (expect.length > 0) {
     throw new Error('This matcher does not take any expected argument.');
   }
 
@@ -194,7 +194,7 @@ const toHaveContext: MatcherFunction = function (
 ) {
   expectType<MatcherContext>(this);
 
-  if (expect.length !== 0) {
+  if (expect.length > 0) {
     throw new Error('This matcher does not take any expected argument.');
   }
 
@@ -215,7 +215,7 @@ const customContext: MatcherFunctionWithContext<CustomContext> = function (
   expectType<CustomContext>(this);
   expectType<void>(this.customMethod());
 
-  if (expect.length !== 0) {
+  if (expect.length > 0) {
     throw new Error('This matcher does not take any expected argument.');
   }
 

packages/expect/src/index.ts

@@ -100,7 +100,7 @@ const getPromiseMatcher = (name: string, matcher: RawMatcherFn) => {
 };
 
 export const expect: Expect = (actual: any, ...rest: Array<any>) => {
-  if (rest.length !== 0) {
+  if (rest.length > 0) {
     throw new Error('Expect takes at most one argument.');
   }
 

packages/expect/src/print.ts

@@ -109,9 +109,9 @@ export const printReceivedConstructorNameNot = (
   expected: Function,
 ): string =>
   typeof expected.name === 'string' &&
-  expected.name.length !== 0 &&
+  expected.name.length > 0 &&
   typeof received.name === 'string' &&
-  received.name.length !== 0
+  received.name.length > 0
     ? `${printConstructorName(label, received, true, false)} ${
         Object.getPrototypeOf(received) === expected
           ? 'extends'

packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapterInit.ts

@@ -158,7 +158,7 @@ export const runAndTransformResultsToJestFormat = async ({
       } else if (testResult.status === 'todo') {
         status = 'todo';
         numTodoTests += 1;
-      } else if (testResult.errors.length) {
+      } else if (testResult.errors.length > 0) {
         status = 'failed';
         numFailingTests += 1;
       } else {
@@ -197,7 +197,7 @@ export const runAndTransformResultsToJestFormat = async ({
   );
   let testExecError;
 
-  if (runResult.unhandledErrors.length) {
+  if (runResult.unhandledErrors.length > 0) {
     testExecError = {
       message: '',
       stack: runResult.unhandledErrors.join('\n'),
@@ -261,7 +261,7 @@ const _addExpectedAssertionErrors = (test: Circus.TestEntry) => {
 const _addSuppressedErrors = (test: Circus.TestEntry) => {
   const {suppressedErrors} = jestExpect.getState();
   jestExpect.setState({suppressedErrors: []});
-  if (suppressedErrors.length) {
+  if (suppressedErrors.length > 0) {
     test.errors = test.errors.concat(suppressedErrors);
   }
 };

packages/jest-circus/src/run.ts

@@ -186,7 +186,7 @@ const _runTest = async (
   const {afterEach, beforeEach} = getEachHooksForTest(test);
 
   for (const hook of beforeEach) {
-    if (test.errors.length) {
+    if (test.errors.length > 0) {
       // If any of the before hooks failed already, we don't run any
       // hooks after that.
       break;
@@ -239,7 +239,7 @@ const _callCircusTest = async (
   const timeout = test.timeout || getState().testTimeout;
   invariant(test.fn, "Tests with no 'fn' should have 'mode' set to 'skipped'");
 
-  if (test.errors.length) {
+  if (test.errors.length > 0) {
     return; // We don't run the test if there's already an error in before hooks.
   }
 

packages/jest-cli/src/run.ts

@@ -92,7 +92,7 @@ const getProjectListFromCLIArgs = (argv: Config.Argv, project?: string) => {
     projects.push(project);
   }
 
-  if (!projects.length && process.platform === 'win32') {
+  if (projects.length === 0 && process.platform === 'win32') {
     try {
       projects.push(tryRealpath(process.cwd()));
     } catch {
@@ -101,7 +101,7 @@ const getProjectListFromCLIArgs = (argv: Config.Argv, project?: string) => {
     }
   }
 
-  if (!projects.length) {
+  if (projects.length === 0) {
     projects.push(process.cwd());
   }
 

packages/jest-config/src/index.ts

@@ -357,7 +357,7 @@ export async function readConfigs(
     hasDeprecationWarnings = parsedConfig.hasDeprecationWarnings;
     globalConfig = parsedConfig.globalConfig;
     configs = [parsedConfig.projectConfig];
-    if (globalConfig.projects && globalConfig.projects.length) {
+    if (globalConfig.projects && globalConfig.projects.length > 0) {
       // Even though we had one project in CLI args, there might be more
       // projects defined in the config.
       // In other words, if this was a single project,
@@ -418,7 +418,7 @@ export async function readConfigs(
     }
   }
 
-  if (!globalConfig || !configs.length) {
+  if (!globalConfig || configs.length === 0) {
     throw new Error('jest: No configuration found for any project.');
   }
 

packages/jest-config/src/normalize.ts

@@ -759,7 +759,7 @@ export default async function normalize(
               const globMatches =
                 typeof project === 'string' ? glob(project) : [];
               return projects.concat(
-                globMatches.length ? globMatches : project,
+                globMatches.length > 0 ? globMatches : project,
               );
             },
             [],

packages/jest-console/src/BufferedConsole.ts

@@ -177,6 +177,6 @@ export default class BufferedConsole extends Console {
   }
 
   getBuffer(): ConsoleBuffer | undefined {
-    return this._buffer.length ? this._buffer : undefined;
+    return this._buffer.length > 0 ? this._buffer : undefined;
   }
 }

packages/jest-core/src/ReporterDispatcher.ts

@@ -112,6 +112,6 @@ export default class ReporterDispatcher {
   }
 
   hasErrors(): boolean {
-    return this.getErrors().length !== 0;
+    return this.getErrors().length > 0;
   }
 }

packages/jest-core/src/SearchSource.ts

@@ -72,14 +72,14 @@ export default class SearchSource {
       stat: 'roots',
     });
 
-    if (config.testMatch.length) {
+    if (config.testMatch.length > 0) {
       this._testPathCases.push({
         isMatch: globsToMatcher(config.testMatch),
         stat: 'testMatch',
       });
     }
 
-    if (config.testPathIgnorePatterns.length) {
+    if (config.testPathIgnorePatterns.length > 0) {
       const testIgnorePatternsRegex = new RegExp(
         config.testPathIgnorePatterns.join('|'),
       );
@@ -89,7 +89,7 @@ export default class SearchSource {
       });
     }
 
-    if (config.testRegex.length) {
+    if (config.testRegex.length > 0) {
       this._testPathCases.push({
         isMatch: regexToMatcher(config.testRegex),
         stat: 'testRegex',
@@ -239,7 +239,7 @@ export default class SearchSource {
     paths: Array<string>,
     collectCoverage: boolean,
   ): Promise<SearchResult> {
-    if (Array.isArray(paths) && paths.length) {
+    if (Array.isArray(paths) && paths.length > 0) {
       const resolvedPaths = paths.map(p =>
         path.resolve(this._context.config.cwd, p),
       );
@@ -280,9 +280,9 @@ export default class SearchSource {
       paths = this.filterPathsWin32(paths);
     }
 
-    if (globalConfig.runTestsByPath && paths && paths.length) {
+    if (globalConfig.runTestsByPath && paths && paths.length > 0) {
       return this.findTestsByPaths(paths);
-    } else if (globalConfig.findRelatedTests && paths && paths.length) {
+    } else if (globalConfig.findRelatedTests && paths && paths.length > 0) {
       return this.findRelatedTestsFromPattern(
         paths,
         globalConfig.collectCoverage,

packages/jest-core/src/SnapshotInteractiveMode.ts

@@ -235,7 +235,7 @@ export default class SnapshotInteractiveMode {
       shouldUpdateSnapshot: boolean,
     ) => unknown,
   ): void {
-    if (!failedSnapshotTestAssertions.length) {
+    if (failedSnapshotTestAssertions.length === 0) {
       return;
     }
 

packages/jest-core/src/cli/index.ts

@@ -121,7 +121,7 @@ export async function runCLI(
 
   const {openHandles} = results;
 
-  if (openHandles && openHandles.length) {
+  if (openHandles && openHandles.length > 0) {
     const formatted = formatHandleErrors(openHandles, configs[0]);
 
     const openHandlesString = pluralize('open handle', formatted.length, 's');

packages/jest-core/src/plugins/UpdateSnapshotsInteractive.ts

@@ -62,7 +62,7 @@ class UpdateSnapshotInteractivePlugin extends BaseWatchPlugin {
     _globalConfig: Config.GlobalConfig,
     updateConfigAndRun: Function,
   ): Promise<void> {
-    if (this._failedSnapshotTestAssertions.length) {
+    if (this._failedSnapshotTestAssertions.length > 0) {
       return new Promise(res => {
         this._snapshotInteractiveMode.run(
           this._failedSnapshotTestAssertions,

packages/jest-core/src/runJest.ts

@@ -43,7 +43,7 @@ const getTestPaths = async (
 ) => {
   const data = await source.getTestPaths(globalConfig, changedFiles, filter);
 
-  if (!data.tests.length && globalConfig.onlyChanged && data.noSCM) {
+  if (data.tests.length === 0 && globalConfig.onlyChanged && data.noSCM) {
     new CustomConsole(outputStream, outputStream).log(
       'Jest can only find uncommitted changed files in a git or hg ' +
         'repository. If you make your project a git or hg ' +

packages/jest-core/src/watch.ts

@@ -243,7 +243,7 @@ export default async function watch(
         isValidPath(globalConfig, filePath),
       );
 
-      if (validPaths.length) {
+      if (validPaths.length > 0) {
         const context = (contexts[index] = createContext(
           contexts[index].config,
           {hasteFS, moduleMap},

packages/jest-diff/src/getAlignedDiffs.ts

@@ -22,7 +22,7 @@ const concatenateRelevantDiffs = (
       reduced +
       (diff[0] === DIFF_EQUAL
         ? diff[1]
-        : diff[0] === op && diff[1].length !== 0 // empty if change is newline
+        : diff[0] === op && diff[1].length > 0 // empty if change is newline
         ? changeColor(diff[1])
         : ''),
     '',
@@ -88,7 +88,7 @@ class ChangeBuffer {
           // A middle substring is a change line.
           this.pushSubstring(substring);
           this.pushLine();
-        } else if (substring.length !== 0) {
+        } else if (substring.length > 0) {
           // The last substring starts a change line, if it is not empty.
           // Important: This non-empty condition also automatically omits
           // the newline appended to the end of expected and received strings.
@@ -173,7 +173,7 @@ class CommonBuffer {
         } else if (i < iLast) {
           // A middle substring is a common line.
           this.pushDiffCommonLine(new Diff(op, substring));
-        } else if (substring.length !== 0) {
+        } else if (substring.length > 0) {
           // The last substring starts a change line, if it is not empty.
           // Important: This non-empty condition also automatically omits
           // the newline appended to the end of expected and received strings.

packages/jest-diff/src/joinAlignedDiffs.ts

@@ -23,7 +23,7 @@ const printDiffLine = (
 ): string =>
   line.length === 0
     ? indicator === ' '
-      ? isFirstOrLast && emptyFirstOrLastLinePlaceholder.length !== 0
+      ? isFirstOrLast && emptyFirstOrLastLinePlaceholder.length > 0
         ? color(`${indicator} ${emptyFirstOrLastLinePlaceholder}`)
         : ''
       : color(indicator)

packages/jest-diff/src/printDiffs.ts

@@ -31,7 +31,7 @@ export const diffStringsUnified = (
   b: string,
   options?: DiffOptions,
 ): string => {
-  if (a !== b && a.length !== 0 && b.length !== 0) {
+  if (a !== b && a.length > 0 && b.length > 0) {
     const isMultiline = a.includes('\n') || b.includes('\n');
 
     // getAlignedDiffs assumes that a newline was appended to the strings.

packages/jest-docblock/src/index.ts

@@ -115,7 +115,7 @@ export function print({
     head +
     line +
     (comments ? printedComments : '') +
-    (comments && keys.length ? start + line : '') +
+    (comments && keys.length > 0 ? start + line : '') +
     printedObject +
     tail
   );

packages/jest-fake-timers/src/legacyFakeTimers.ts

@@ -224,11 +224,11 @@ export default class FakeTimers<TimerRef = unknown> {
       // Some of the immediate calls could be enqueued
       // during the previous handling of the timers, we should
       // run them as well.
-      if (this._immediates.length) {
+      if (this._immediates.length > 0) {
         this.runAllImmediates();
       }
 
-      if (this._ticks.length) {
+      if (this._ticks.length > 0) {
         this.runAllTicks();
       }
     }

packages/jest-haste-map/src/crawlers/node.ts

@@ -144,7 +144,7 @@ function findNative(
     args.push('-type', 'f');
   }
 
-  if (extensions.length) {
+  if (extensions.length > 0) {
     args.push('(');
   }
   extensions.forEach((ext, index) => {
@@ -154,7 +154,7 @@ function findNative(
     args.push('-iname');
     args.push(`*.${ext}`);
   });
-  if (extensions.length) {
+  if (extensions.length > 0) {
     args.push(')');
   }