Fix Array matching

Fixes matching type Array for arrays created in a new context.
jestjs · May 27, 2024 · b791c90 · b791c90
1 parent b7ae0b8
commit b791c90
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/expect/src/__tests__/asymmetricMatchers.test.ts b/packages/expect/src/__tests__/asymmetricMatchers.test.ts
@@ -21,6 +21,7 @@ import {
   stringNotContaining,
   stringNotMatching,
 } from '../asymmetricMatchers';
+import { runInNewContext } from 'node:vm';
 
 test('Any.asymmetricMatch()', () => {
   class Thing {}
@@ -51,6 +52,7 @@ test('Any.asymmetricMatch() on primitive wrapper classes', () => {
     any(Boolean).asymmetricMatch(new Boolean(true)),
     any(BigInt).asymmetricMatch(Object(1n)),
     any(Symbol).asymmetricMatch(Object(Symbol())),
+    any(Array).asymmetricMatch(runInNewContext('[];')),
     /* eslint-enable */
   ]) {
     jestExpect(test).toBe(true);

diff --git a/packages/expect/src/asymmetricMatchers.ts b/packages/expect/src/asymmetricMatchers.ts
@@ -136,6 +136,10 @@ class Any extends AsymmetricMatcher<any> {
       return typeof other == 'object';
     }
 
+    if (this.sample == Array) {
+      return Array.isArray(other)
+    }
+
     return other instanceof this.sample;
   }
 
@@ -164,6 +168,10 @@ class Any extends AsymmetricMatcher<any> {
       return 'boolean';
     }
 
+    if (Array.isArray(this.sample)) {
+      return 'array';
+    }
+
     return fnNameFor(this.sample);
   }