Implement module.parent.filename

jestjs · Oct 6, 2017 · e0b5bdc · e0b5bdc
1 parent cd3becf
commit e0b5bdc
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 6 deletions.
diff --git a/packages/jest-runtime/src/__tests__/runtime_require_module.test.js b/packages/jest-runtime/src/__tests__/runtime_require_module.test.js
@@ -8,7 +8,8 @@
 
 'use strict';
 
-const path = require('path');
+import path from 'path';
+import slash from 'slash';
 
 let createRuntime;
 
@@ -34,7 +35,7 @@ describe('Runtime requireModule', () => {
       );
       expect(exports.parent).toEqual({
         exports: {},
-        filename: 'mock.js',
+        filename: '',
         id: 'mockParent',
         require: expect.any(Function),
       });
@@ -46,7 +47,19 @@ describe('Runtime requireModule', () => {
         runtime.__mockRootPath,
         'inner_parent_module',
       );
-      expect(exports).toEqual('This should happen');
+      expect(exports.outputString).toEqual('This should happen');
+    }));
+
+  it('resolve module.parent.filename correctly', () =>
+    createRuntime(__filename).then(runtime => {
+      const exports = runtime.requireModule(
+        runtime.__mockRootPath,
+        'inner_parent_module',
+      );
+
+      expect(slash(exports.parentFileName.replace(__dirname, ''))).toEqual(
+        '/test_root/node_modules/module-needing-parent/index.js',
+      );
     }));
 
   it('provides `module.filename` to modules', () =>

diff --git a/..._tests__/test_root/node_modules/module-needing-parent/node_modules/parent-module/index.js b/..._tests__/test_root/node_modules/module-needing-parent/node_modules/parent-module/index.js
diff --git a/packages/jest-runtime/src/__tests__/test_root/node_modules/parent-module/index.js b/packages/jest-runtime/src/__tests__/test_root/node_modules/parent-module/index.js
diff --git a/packages/jest-runtime/src/index.js b/packages/jest-runtime/src/index.js
@@ -77,7 +77,6 @@ const getModuleNameMapper = (config: ProjectConfig) => {
 
 const mockParentModule = {
   exports: {},
-  filename: 'mock.js',
   id: 'mockParent',
 };
 
@@ -497,6 +496,7 @@ class Runtime {
     localModule.paths = this._resolver.getModulePaths(dirname);
     localModule.require = this._createRequireImplementation(filename, options);
     localModule.parent = Object.assign({}, localModule.parent, {
+      filename: lastExecutingModulePath,
       require: this._createRequireImplementation(
         lastExecutingModulePath,
         options,