Skip to content

Commit

Permalink
fix typecheck:tests type err
Browse files Browse the repository at this point in the history
  • Loading branch information
@jeysal
jeysal committed Dec 2, 2022
1 parent 6e5b1d6 commit ef91356
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/jest-snapshot/src/__tests__/mockSerializer.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test('mock with 0 calls and default name', () => {
});

test('mock with 2 calls, 1 return, 1 throw', () => {
const fn = jest.fn(value => {
const fn = jest.fn((value: number) => {
if (value % 2 === 0) {
return value * 2;
} else {
Expand Down

3 comments on commit ef91356

@SimenB
Copy link
Member

@SimenB SimenB commented on ef91356 Dec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeysal seems this broke CI?

@jeysal
Copy link
Contributor Author

@jeysal jeysal commented on ef91356 Dec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB nope, it's a fix for two of three errors that appeared on CI on all PRs. The third one that is still breaking CI is weird and hard to fix and I'm not sure about it. The actual cause for the three new errors was very likely the TS update, but it's very strange that the errors didn't appear on the PR of that update or the merge commit itself, only later. See #13633 (comment)

@mrazauskas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeysal Perhaps it would make sense opening a PR downgrade the TS version? Just to see if that’s the problem. I could do a bit later.

The failure is odd indeed. I was looking at it. Feels like it could be caused by some change in GH infrastructure. Because PRs and commits were not failing. Also it does not reproduce locally.

Please sign in to comment.