Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ts-jest official #2191

Closed
Igmat opened this issue Nov 30, 2016 · 7 comments
Closed

Make ts-jest official #2191

Igmat opened this issue Nov 30, 2016 · 7 comments

Comments

@Igmat
Copy link

Igmat commented Nov 30, 2016

We are working on ts-jest that allows easier Jest integration with TypeScript.
Currently it provides preprocessor and testResultsProcessor to correctly handle line numbers when error happened and coverage reamapping.
It covers most of use cases, has simple docs and covered by integration tests.
There are still some issues, but some of them requires new API in Jest itself and others will be solved soon.
It also could be great if we'll be able to provide zero-config(kulshekhar/ts-jest#13) as it done for babel-jest. I guess I'm able to provide PR that implements it.

So, I'm curious if you are interested in this improvement or Jest won't support such deep TypeScript integration?

@cpojer
Copy link
Member

cpojer commented Nov 30, 2016

I'm happy to accept PRs and make this official provided they follow the code standards, are easy to maintain and well tested. I only want to take this dependency on if we have some guidelines in place to make sure we aren't just growing this repo for no reason :)

@cpojer
Copy link
Member

cpojer commented Feb 25, 2017

@Igmat do you have a path forward for this? Any idea how we could make this work? I think for now I'd prefer ts-jest to be maintained outside of the Jest repo but if there are some easy things we can do to make it easier to set up, I'm happy to hear your opinion.

@japhar81
Copy link

japhar81 commented Mar 5, 2017

@cpojer @Igmat I use ts-jest, but im curious -- why not just make typescript a first-class citizen in jest the same way Babel is? A quick scan of the code looks like it's not terribly hard to just duplicate the babel pattern and make .ts/.tsx work the same way out of the box?

I'm happy to take a stab at making it happen if it's something that hasn't already been discarded as an idea -- i can't find any confirmation if it's been discussed/discarded?

@cpojer
Copy link
Member

cpojer commented Mar 6, 2017

@Igmat was exploring this in the past and it did require a bunch of changes as it is more involved than the babel-jest stuff. I'd love for it to be revisited and figure out how to make this work.

@SimenB
Copy link
Member

SimenB commented Oct 8, 2017

Babel 7 supports typescript, and stuff like this exists: https://www.npmjs.com/package/babel-plugin-transform-typescript

Will that help? Will stuff just work:tm: for TS? Or do we still need some other integration?

@cpojer
Copy link
Member

cpojer commented Oct 8, 2017

@SimenB yeah, I honestly think that makes the most sense. I think latest babel-jest already works with Babel 7, so let's go down that route.

@cpojer cpojer closed this as completed Oct 8, 2017
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants