testNamePattern runs beforeAll/afterAll in excluded suites

[felipeochoa]

Given a test file with the following contents:

describe("abc", function() {
  it("runs abc", function() {});
});

describe("def", function() {
  beforeAll(() => fail("Ran beforeAll for def"));
  it("does not run def", function() {
    fail("ran def");
  })
});

running jest -t abc runs the beforeAll callback in the def suite. The failure is reported under def › does not run def (though the summary at the bottom says "1 skipped, 1 passed, 2 total")

I would have expected the beforeAll function not to have run.

felipeochoa/jest-bug-demo is a basic repro repo.

Tested on jest 21.2.1, node 8.9.0, and yarn 1.0.1

[rogeliog]

Hi! Thanks for reporting, I'm also able to reproduce it

[rogeliog]

Seems like a duplicate of #4487 right?

[rogeliog]

cc: @aaronabramov

[timjacobi]

@rogeliog @aaronabramov
Is this being worked on and do you think this would be suitable to work on for someone that's new to the codebase? If the answers are no and yes then I would like to look into this.

[rogeliog]

I think @aaronabramov would know better than me 😃

[aaronabramov]

i think this is the way jasmine runs tests. I think it was fixed in Jasmine at some point, but we're still using the old/custom version of it.
@timjacobi you can try to find this issue in Jasmine repo, see how they fixed it and do something similar in our jasmine fork!

[timjacobi]

@aaronabramov #4166 (comment) says you are working on jest-circus which should fix the issue. Is this still the case?

[aaronabramov]

@timjacobi unfortunately jest-circus is not the priority right now :(

[rogeliog]

This seems to be the PR that fixed it in the Jasmine side, jasmine/jasmine#1225

[eyelidlessness]

My issue (#5593) was closed as a duplicate of this one, but I think mine captures several test cases that are not covered here, so I'll link to the repl.it repro in case it's helpful.

[eisenbergrobin]

Any news on this issue ?

[SimenB]

We tried to port the fix from Jasmine in #5051, but it didn't work. Help very much welcome!

[SimenB]

Fixed in #6234

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.