ProjectConfig.name to ProjectConfig.id #10228
Conversation
I changed the **name: string** to **id: string**.
|
Hi @Thusal06! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Note to admin or author: Looks like this is a duplicate of #10299 (see #10229 (comment)), and this one can be closed. |
|
Closing this as it appears to be incomplete (code won't typecheck unless this is also changed in other places). If you still want to complete this feel free to open another PR with all the changes that are required. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I changed the name: string to id: string.
Summary
#10013
Test plan