-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert usage of Escalade and yargs@16 as they breaks Node 13 #10599
Conversation
It's not only escalade. Reported comment was about yargs. |
Good call, I'll rollback yargs as well |
node-notifier also depends on uuid 8.3 with es modules support |
|
Bah. I'll install node 13 and verify |
Rolling |
Almost worth a quick Jest 27 after this just reverting this commit and updating |
@SimenB Using uuid would be fine by me, can also add node 13 to test engines. Not able to do it right away, though, as I am on a short vacation without access to a laptop. |
It's specifically old versions of node 13, not the latest ones. Probably not worth it |
That said, we've been installing a version of Jest itself will use |
I'll keep |
Ah, great news! I still think we'll wait until Jest 27 regardless (#9921) |
No problem, just letting you know :) Everyone has/had this problem thanks to Node 13.x experiments. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #10596
This reverts commit 0a9e77d.
Let's land it for Jest 27 instead
Test plan
🤷