use already read cpus variable only once and improve code little usi…

[sktguha]

…ng Math.max

Summary

This PR improves the code of getMaxWorkers.ts a little bit, use already read cpus variable only once and improve code little using Math.max

Test plan

Unfortunately I am getting a typescript issue at the yarn build stage,

18 export declare function watch(path: string, since: number, handler: WatchHandler);

So unable to run tests. Could someone who has the environment set up checkout this branch and run the tests ?
Anyways the code change is really small

Thanks
Saikat Guha
sktguha@gmail.com

[sktguha]

getting mercurial not installed in the CI. not sure why. I definitely didn't make any changes in that regard.

[sktguha]

Hello could anyone take a look at this please ?

[SimenB]

thanks!

[sktguha]

Hello thanks for approval,

made the requested changes,
Could you merge if ok now, however as mentioned earlier , unable to test on my machine due to above mentioned error in the test plan section.
Let's hope the CI runs all the checks

[SimenB]

To be able to run locally, you can apply the diff from https://github.com/fsevents/fsevents/pull/348/files in you node_modules

[sktguha]

All right sure thanks will do that and update soon

[SimenB]

@sktguha I've rolled back the version of fsevents in this repo, so rebasing and running yarn will give you a working version of fsevents

[sktguha]

@SimenB oh that's great. Thanks let me try it out and run the tests locally and update here

[SimenB]

@sktguha ping 🙂

[sktguha]

oh hi sorry, forgot. lemme update PR 🙂

[sktguha]

I am getting the following errors on running yarn test after rebasing with master . But it doesn't seem to be related to my changes. @SimenB

[sktguha]

@SimenB

[sktguha]

@SimenB bump 😀

[SimenB]

Hey! SOrry about the slow response.

Linting is passing on CI on master. Did you run yarn? I'd attempt to push - you haven't touched those files so it won't matter.

If you want to just run tests you can run yarn jest (instead of test)

[sktguha]

Yesy changes are already pushed. don't have anything else to push 🙂

[SimenB]

This PR does not fail lint

So there is something with your local clone in this case

[sktguha]

Huh alright. Actually I think it can be merged. there is nothing wrong with the part of the code I have changed. The issues are not related to that part of code.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.