-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update dependencies for @jest/fake-timer #11170
Conversation
Hi @HonzaMac! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks @HonzaMac! I haven't done this since the types of v7 are really bad. Should probably try to fix that though so we can update. sinonjs/fake-timers#356 (comment) CI is failing since you haven't updated the lockfile - just run |
- Upgrading `@sinonjs/fake-timers` to version v7
@SimenB Thank you! |
@HonzaMac we have runtime errors as well that would be good to fix |
Seems those runtime errors are due wrong typings. I will try to wrote those types. |
@SimenB Thank you! I had trouble running jest clone locally and specially to extend test suite to verify "refresh()" method. You were faster! Thanks |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@sinonjs/fake-timers
to version v7Fixes #11169.
Summary
Test plan