expect: Export expect as default export #11490
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows types to be exported as well.
Fixes #11487
Strictly speaking a breaking change, as expect = require('expect') not longer works, but as this is usually used as a global, this shouldn't be much of an issue.
Summary
To recap #11487 , the "expect" doesn't export the actual
Matchers
interface which theexpect()
function returns, but rather an interface which extends Matchers. This means that you can't extend the returned interface with typescript's declaration merging.This the cleaner solution, which replaces the
export =
withexport default
which allows re-exporting types.Test plan
Is it possible to test the types?
packages/expect/src/__tests__/extend.test.ts
has TS errors, but still shows up green.