Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix wrong MockFunctions.md log result #11588

Closed
wants to merge 1 commit into from
Closed

docs: fix wrong MockFunctions.md log result #11588

wants to merge 1 commit into from

Conversation

iibe
Copy link

@iibe iibe commented Jun 18, 2021

It seems a little strange to me. Why are we showing the first and second arguments of the first function call (lines 108-109 of the MockFunctions.md). It would be more correct to write .calls[0][0] and .calls[1][0] to show the first argument of function
Screenshot_1
calls.

MockFunctions.md typo fixed

Summary

It fixes documentation typo. Therefore, the reader will correctly understand the text if we fix this typo.

Test plan

http://prntscr.com/15t2xmb

It seems a little strange to me. Why are we showing the first and second arguments of the first function call (lines 108-109 of the MockFunctions.md). It would be more correct to write .calls[0][0] and .calls[1][0] to show the first argument of funtion calls.

MockFunctions.md typo fixed
@facebook-github-bot
Copy link
Contributor

Hi @iibe!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #11588 (f90b795) into master (7be63ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11588   +/-   ##
=======================================
  Coverage   69.00%   69.00%           
=======================================
  Files         312      312           
  Lines       16331    16331           
  Branches     4730     4730           
=======================================
  Hits        11269    11269           
  Misses       5034     5034           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be63ef...f90b795. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@seastian
Copy link
Contributor

Same as #11556

@iibe
Copy link
Author

iibe commented Jun 19, 2021

Hmm, yeah. Thanks. I didn't notice it.

@iibe iibe closed this Jun 19, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2021
@iibe iibe deleted the fix-mock-functions-doc branch July 20, 2021 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants