-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced substr
with substring
#12066
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12066 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 324 324
Lines 16669 16669
Branches 4814 4814
=======================================
Hits 11483 11483
Misses 5153 5153
Partials 33 33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I left one inline comment, but in addition to that, could you update the changelog?
🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
substr
with substring
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
JS string substr gives deprecated warning it should be avoided to use.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr